harvard-lil / capstone

CAP database scripts.
MIT License
189 stars 44 forks source link

Rek reporter slug #2163

Closed kilbergr closed 1 year ago

kilbergr commented 1 year ago

This PR handles an issue Jack pointed out--that the reporters' slugs are not necessarily unique. After some digging, we identified that only two reporters that shared slugs actually have volumes/cases within them, so this code differentiates the identical slugs from each other. It also changes the way we check for reporters without volumes--we realized that volume_count did not reflect actual volume count, so now we're using out_of_scope instead, which seems like a heartier measure.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2163 (11ae1fd) into develop (2269ae1) will decrease coverage by 0.01%. Report is 1 commits behind head on develop. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2163      +/-   ##
===========================================
- Coverage    62.19%   62.18%   -0.01%     
===========================================
  Files          107      107              
  Lines        11767    11770       +3     
===========================================
+ Hits          7318     7319       +1     
- Misses        4449     4451       +2     

see 1 file with indirect coverage changes