harvard-lts / fits

File Information Tool Set

http://fitstool.org

GNU Lesser General Public License v2.1

92 stars 46 forks source link

Reorder jpylyzer tool #376

Closed daveneiman closed 1 year ago

daveneiman commented 1 year ago

Resolves Issue: LIBDRS-9064

Other Relevant Links (Mailing list discussion, related pull requests, etc.)

What does this Pull Request do?

In the fits.xml configuration file(s) the jypylyzer tool has been moved above the JHOVE tool so that jpylyzer output for JPEG 2000 (jp2) files takes precedence. Expected output files for tests have been updated to reflect this change.

How should this be tested?

Run the test suite from a Docker container as described in README.md.

build FITS without running tests - mvn clean package -DskipTests
build a Docker container - docker build -f docker/Dockerfile-test -t fits-test .
Run the test suite - docker run --rm -vpwd:/fits -v ~/.m2:/root/.m2 fits-test mvn clean test

Test coverage

Yes/No: Are changes in this pull-request covered by:

unit tests? yes
integration tests? yes

Interested parties

@pwinckles @awoods @cvicary

daveneiman commented 1 year ago

Because every XML test fails when the order of the tools in the statistics section has changed. Unfortunate but needed to be done.