refactor: replaced some Ant components with MUI components.

[SariHop]

Description

158

Started to replace Ant components with MUI components. There is more progress to be made, but I would like to get feedback on my initial work.

[github-actions[bot]]

Preview: https://s3.amazonaws.com/noam-gaash.co.il/9438827734/open-bus/0f12388af038e026475519a0f7901ab4ab9132ce/index.html Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/9438827734/open-bus/0f12388af038e026475519a0f7901ab4ab9132ce/storybook/index.html

[NoamGaash]

Hi, thanks for your efforts! Please consider configuring eslint in your ide, or run npm run lint:fix to fix lint errors

[SariHop]

I ran the command npm run lint:fix. This is my first PR, so I would like to know if there is anything else I should do or know before I commit the changes.

[shootermv]

I think you should be more pesific about - which components you are about to replace ("some" is too general). my opinion - it would be even better to replace only one component per step...

On Sun, May 19, 2024, 09:48 Sari H @.***> wrote:

I ran the command npm run lint:fix. This is my first PR, so I would like to know if there is anything else I should do or know before I commit the changes.

— Reply to this email directly, view it on GitHub https://github.com/hasadna/open-bus-map-search/pull/752#issuecomment-2119124202, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKGMHX6ZLXNFVVIAKISNQLZDBDL5AVCNFSM6AAAAABH2WCCNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGEZDIMRQGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[NoamGaash]

Hi @SariHop , it's always good to commit any improvement. Right now, it's hard to check your pull request as it have many warnings on it. It is recommended to solve all lint errors before asking for a code review

[SariHop]

This is more information about my changes:

• Bug report form: Use CardContent and Card from MUI and change the uploud icon
• About form : Switch the Space(Ant) with Stack(MUI)
• Imported all typografy from MUI .
• Imported all  alert from MUI.
• Switched all Spin (Ant) with CircularProgress (MUI).

[shootermv]

one little problem i saw (not sure if it has something with the change...) there are 2 dollar icons at the topbar

[NoamGaash]

@shootermv Great catch! I guess we really like money here :stuck_out_tongue_winking_eye:

It's not related to this pull request but it's something we should fix. Do you want to open a pull request?

[shootermv]

Thanks! Not sure about PR, but I will open an issue.

[SariHop]

The differences between MUI and Ant's text header size are quite significant. I found this size to be the most suitable so that the title would be noticeable and readable. @NoamGaash

[NoamGaash]

@SariHop Thanks!