hasadna / open-bus-map-search

open-bus-map-search
https://open-bus-map-search.hasadna.org.il/dashboard
MIT License
56 stars 90 forks source link

test: add test for trip existence #901

Closed YaelChen closed 2 weeks ago

YaelChen commented 3 weeks ago

Description

My first test, created by codegen, Choosing params under "קיום נסיעות" and organize by date/hour.

github-actions[bot] commented 3 weeks ago

Preview: https://s3.amazonaws.com/noam-gaash.co.il/11649842227/open-bus/117/index.html Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/11649842227/open-bus/117/storybook/index.html Test Report (if available): 'https://s3.amazonaws.com/noam-gaash.co.il/11649842227/open-bus/6087e9417e5bef80fb4b988861bbcbd04b4c9062/test-results/index.html'

NoamGaash commented 3 weeks ago

Thanks for the contribution! Truly appreciate it. Please run npm run lint:fix as described here

YaelChen commented 3 weeks ago

Thanks @NoamGaash, forgot about the lint. only installed it now. do I need to run it and push again without the useless "expect" (that I first thought i'll leave for future use)?

NoamGaash commented 3 weeks ago

Exactly, thanks! once the lint issues are solved, the test statuses should be green

YaelChen commented 2 weeks ago

It still fails, something about a render component I don't know?

  22 |   let renderedComponent: RenderResult
  23 |   beforeEach(() => {
> 24 |     renderedComponent = render(
     |                               ^
  25 |       <ArrivalByTimeChart data={testBusData} operatorId={testBusData[0].id} />,
  26 |     )
  27 |   })

it does mention I need to ask the APPLITOOLS_API_KEY, as it is not defined. don't know if it has something to do with it.

NoamGaash commented 2 weeks ago

Hi Yael, it's not you fault and I apology for the bad experience, I have probably misconfigured something with the visual tests - the error Test timeout of 180000ms exceeded while running "afterEach" hook indicate that we have some performance problems, it's not really test failures. I pushed a commit (https://github.com/hasadna/open-bus-map-search/commit/121e6d53677136a22e9be0b4252c7e7df758df30) to ignore this error and remove the timeout, and I'll try again.

regarding the API key - it's just a warning - the visual tests are skipped by default when your API key is not configured on your machine. If you want to execute the visual tests I'll send you the API key but it's really not that important, I hope that the fix I pushed to main will solve this error

NoamGaash commented 2 weeks ago

Great job! Thanks you :clap: Feel free to merge