hashgraph / hedera-block-node

New Block Node services
Apache License 2.0
24 stars 3 forks source link

refactor: implement agreed upon changes based on discussion (#266) #336

Closed ata-nas closed 2 weeks ago

ata-nas commented 2 weeks ago

Description:

Implement agreed upon changes from discussion #266

Related issue(s):

Fixes #305

Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.05%. Comparing base (401b645) to head (93c2c06). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #336 +/- ## ============================================ + Coverage 93.98% 94.05% +0.07% - Complexity 288 300 +12 ============================================ Files 66 68 +2 Lines 1163 1177 +14 Branches 83 82 -1 ============================================ + Hits 1093 1107 +14 Misses 57 57 Partials 13 13 ``` | [Files with missing lines](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/336?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | Coverage Δ | | |---|---|---| | [...a/com/hedera/block/common/utils/FileUtilities.java](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/336?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fhedera%2Fblock%2Fcommon%2Futils%2FFileUtilities.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvY29tL2hlZGVyYS9ibG9jay9jb21tb24vdXRpbHMvRmlsZVV0aWxpdGllcy5qYXZh) | `100.00% <100.00%> (ø)` | | | [...a/com/hedera/block/common/utils/MathUtilities.java](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/336?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fhedera%2Fblock%2Fcommon%2Futils%2FMathUtilities.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvY29tL2hlZGVyYS9ibG9jay9jb21tb24vdXRpbHMvTWF0aFV0aWxpdGllcy5qYXZh) | `100.00% <100.00%> (ø)` | | | [...a/com/hedera/block/common/utils/Preconditions.java](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/336?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fhedera%2Fblock%2Fcommon%2Futils%2FPreconditions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvY29tL2hlZGVyYS9ibG9jay9jb21tb24vdXRpbHMvUHJlY29uZGl0aW9ucy5qYXZh) | `100.00% <100.00%> (ø)` | | | [...com/hedera/block/common/utils/StringUtilities.java](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/336?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fhedera%2Fblock%2Fcommon%2Futils%2FStringUtilities.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvY29tL2hlZGVyYS9ibG9jay9jb21tb24vdXRpbHMvU3RyaW5nVXRpbGl0aWVzLmphdmE=) | `100.00% <100.00%> (ø)` | | | [...m/hedera/block/server/mediator/MediatorConfig.java](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/336?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fhedera%2Fblock%2Fserver%2Fmediator%2FMediatorConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2hlZGVyYS9ibG9jay9zZXJ2ZXIvbWVkaWF0b3IvTWVkaWF0b3JDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...m/hedera/block/server/notifier/NotifierConfig.java](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/336?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fhedera%2Fblock%2Fserver%2Fnotifier%2FNotifierConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2hlZGVyYS9ibG9jay9zZXJ2ZXIvbm90aWZpZXIvTm90aWZpZXJDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | |