hashicorp-forge / hermes

A document management system
Mozilla Public License 2.0
1.82k stars 100 forks source link

Pluggable search interface? #495

Open leelynne opened 11 months ago

leelynne commented 11 months ago

Hello! I see there is not currently a plan for a pluggable search engine (https://github.com/hashicorp-forge/hermes/issues/449).

Would you be open to accepting a change that creates go search engine interface (but the only and default implementation is Algolia)? I could make this at your direction or I could propose an interface and we could go from there.

Thanks for the work on this great project.

jfreda commented 11 months ago

👋 Hi @leelynne and thanks for the interest in Hermes! I think we'd probably be open to this once we remove v1 of the Hermes API which is planned for next month. I think this should make things much easier for a search engine interface. I'll keep this issue open and we'll reach out once ready!

leelynne commented 11 months ago

Awesome, thanks!

Akshay-Thakare commented 8 months ago

@jfreda Just curious, From an enterprise perspective, why wasn't the Google Drive search API supported? Ref: https://developers.google.com/drive/api/guides/ref-search-terms

jfreda commented 8 months ago

@jfreda Just curious, From an enterprise perspective, why wasn't the Google Drive search API supported? Ref: https://developers.google.com/drive/api/guides/ref-search-terms

👋 Hi @Akshay-Thakare - we made a design decision to use Algolia based on good experiences with its search functionality vs. Google Drive search.