hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.
http://boundary-ui.vercel.app
Other
87 stars 28 forks source link

fix: πŸ› pass current url to maintain session #2472

Closed DhariniJeeva closed 3 weeks ago

DhariniJeeva commented 3 weeks ago

βœ… Closes: https://hashicorp.atlassian.net/browse/ICU-14963

Description

The pr fixes session getting unauthorized on the route refresh, I noticed the session data becomes empty during the application route's beforemodel hook when an HCP cluster URL is used, causing an abrupt logout.

Passing in the full route name fixes the issue.

Screenshots (if appropriate)

https://github.com/user-attachments/assets/cd66f581-da98-4cc9-b477-f60edc3fd20d

How to Test

Use the 0.20.0 installer. It contains DC 2.2.0-beta.ts.1, which has 0.17.0 CLI.

Open DC and connect to an HCP cluster. [let me know if you need one to test]

Wait until targets load.

Navigate to the settings page.

Click on thepause button, it should say paused.

Once paused, clicking on resume btn should not throw an error, you should be able to stay on the same page and perform other actions

Checklist

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
boundary-ui βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 4, 2024 7:41pm
boundary-ui-desktop βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 4, 2024 7:41pm
calcaide commented 3 weeks ago

@DhariniJeeva I notice the How to test steps, are how to reproduce the issue, is that correct?

The process I followed to test this PR:

DhariniJeeva commented 3 weeks ago

@DhariniJeeva I notice the How to test steps, are how to reproduce the issue, is that correct?

The process I followed to test this PR:

  • Checkout boundary-ui to this branch.
  • Start DC within dev env (mirage off).
  • Connect to an HCP cluster.
  • Pause and later on resume the client age without showing any error.

oops yes, I will update the description, thanks for the catch