hashicorp / ghaction-terraform-provider-release

Reusable GitHub Action Workflows for releasing HashiCorp, partner, and community Terraform Providers
Mozilla Public License 2.0
15 stars 9 forks source link

Use v5.1.0 of goreleaser-action for v3 of community.yml #102

Open taherkk opened 1 month ago

taherkk commented 1 month ago

Currently the v3 of community.yml uses v5.0.0 of goreleaser-action which uses latest version of goreleaser. The current release of goreleaser is v6 which has breaking changes and it is causing issues with our github workflows.

community.yml should be using v5.1.0 of goreleaser-action which uses v1 of the goreleaser package and not the latest.

Downloading https://github.com/goreleaser/goreleaser/releases/download/v2.1.0
/goreleaser_Linux_x86_64.tar.gz
Extracting GoReleaser
/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/e6ea2d0d-ca96-42ca-9c9c-449891796f90 -f /home/runner/work/_temp/48cd3fbd-87ec-4b8e-b89e-7e5780d64b1a
GoReleaser latest installed successfully
/opt/hostedtoolcache/goreleaser-action/2.1.0/x64/goreleaser release --clean
  • only configurations files on version: 2 are supported, yours is version: 0, please update your configuration
  ⨯ release failed after 0s                  error=only configurations files on version: 2 are supported, yours is version: 0, please update your configuration
Error: The process '/opt/hostedtoolcache/goreleaser-action/2.1.0/x64/goreleaser' failed with exit code 1
deniseyu commented 1 month ago

Hi @taherkk, thanks for opening this issue!

This version contained a major version upgrade in goreleaser. Please follow the guidance in goreleaser's release notes to upgrade: https://github.com/goreleaser/goreleaser/releases/tag/v2.0.0

Otherwise you can pin your repo to use v4.1.0 of this workflow if you're not ready to upgrade.

taherkk commented 1 month ago

Hi @deniseyu,

Can you please share a link to the tag v4.1.0 because I can't find it in this repo.

deniseyu commented 1 month ago

@taherkk sorry, typo - I meant v4.0.1! https://github.com/hashicorp/ghaction-terraform-provider-release/releases/tag/v4.0.1

taherkk commented 1 month ago

@deniseyu ,

That wouldn't help since it too uses v5.0.0 of the goreleaser-action, since it uses the latest tag for goreleaser and will end up using v2 of goreleaser, which is analogus to the current situation where we are using v3 of the this workflow and it is using v2 of goreleaser while it should be using v1.

I think I wasn't clear enough in my first comment. When I said that the community.yml should use v5.1.0 of goreleaser-action, I meant that v4 and below of this workflow should be using v5.1.0 to keep using v1 of the goreleaser while v5 of this workflow uses the v2 of goreleaser that has breaking changes.