[azurekeyvault] remove autorest dependencies

hashicorp / go-kms-wrapping

KMS wrapping libraries split out from Vault

Mozilla Public License 2.0

59 stars 45 forks source link

[azurekeyvault] remove autorest dependencies #224

Closed kschoche closed 7 months ago

kschoche commented 10 months ago

Removes deprecated autorest library calls from azurekeyvault
Removes dead functions
Fixes a bug whereby we do not pass in the cloudConfigOptions to azidentity.NewDefaultAzureCredential() and azidentity.NewClientSecretCredential()

kschoche commented 10 months ago

The options you're removing all appear to be valid options. Can you explain a bit why you're removing them? Thanks! Maybe I'm misunderstanding, are you referring to the unused functions that were removed in options.go ? I can definitely revert that bit if I've misunderstand where they are used.

jimlambrt commented 10 months ago

See all the opts.* in SetConfig(...) to see how they're used.

kschoche commented 10 months ago

See all the opts.* in SetConfig(...) to see how they're used.

Thanks for pointing that out, my IDE had it all flagged as unused, my mistake for not checking further!