hashicorp / memberlist

Golang package for gossip based membership and failure detection
Mozilla Public License 2.0
3.61k stars 435 forks source link

fix node state export #298

Open YuhangMa1117 opened 5 months ago

YuhangMa1117 commented 5 months ago

This commit fix the https://github.com/hashicorp/memberlist/issues/266 that get the confusion state of node when Members called, due to c192837f commit which involved two state varibale for one node.

hashicorp-cla commented 5 months ago

CLA assistant check
All committers have signed the CLA.

dhilgarth commented 1 month ago

Would this PR also fix this related issue? https://github.com/hashicorp/memberlist/issues/293

YuhangMa1117 commented 1 month ago

Would this PR also fix this related issue? #293

I believe that #293 brings up a subject which is similar to mine, but the solutions he proposed may cause a considerable diff which is not so graceful. This PR will only fix the Members problem but cannot fix #293 because of the State is used in NotifyLeave, and for this reason this PR is more clearly.