simplify logic in queue's GetBroadcasts

mbver commented 3 months ago

getting an item to broadcast based on priority of

transmits: the lower the better
msgLen: the longer the better
id: the higher the better starting from the front of queue check each item. if it is ok to be broadcasted. picked it and move on to the next. if it is not ok (length doesn't fit), still move on to the next. stop when there's no space for msgs or reach the end of queue. for all items that are picked, first delete them from the queue. then increase its transmits. if the item's transmit is over transmitLitmit, finish it. Else insert it back to the queue for the next round of GetBroadcast. The test is updated with variable message length and transmits.

hashicorp-cla-app[bot] commented 3 months ago

All committers have signed the CLA.

hashicorp-cla-app[bot] commented 3 months ago

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

mbver commented 2 months ago

hi @rboyer , could you please give me some feedbacks when you have time? thank you.

hashicorp / memberlist

simplify logic in queue's GetBroadcasts #301