search

hashicorp / memberlist

Golang package for gossip based membership and failure detection
Mozilla Public License 2.0
3.61k stars 435 forks source link

do not fire false ackMessage in timeout. check timeout in caller #304

Open mbver opened 2 months ago

mbver commented 2 months ago

firing a false ackMessage at timeout will cause additional checks for v.Complete in the caller and further complicates handling by resending false ackMessage. instead, only check the timeout in the caller where it is needed. therefore, there's no need for the field Complete in ackMessage.

mbver commented 2 months ago

hi @armon , could you please give a few comments on this when you have time?