add support for sata disk_interface in QEMU builder

hashicorp / packer-plugin-qemu

Packer plugin for QEMU Builder

https://www.packer.io/docs/builders/qemu

Mozilla Public License 2.0

59 stars 44 forks source link

add support for sata disk_interface in QEMU builder #18

Open ghost opened 3 years ago

ghost commented 3 years ago

This issue was originally opened by @Wenzel as hashicorp/packer#3983. It was migrated here as a result of the Packer plugin split. The original body of the issue is below.

Hi !

the QEMU builder currently supports 4 types for the disk_interface configuration :

ide
scsi
virtio
virtio-scsi

Would it be possible to add support for sata as well ?

Wenzel commented 1 week ago

This PR was supposed to add SATA support: https://github.com/hashicorp/packer-plugin-qemu/pull/54#pullrequestreview-877649727

However it's incomplete and unusable at this stage: https://github.com/hashicorp/packer-plugin-qemu/issues/146

@nywilken should we remove this option from the docs until we figure out a way to fix SATA support ? How difficult would it be to add an ICH9 AHCI controller when SATA is requested ?

I'm also wondering if we should check the machine_type, since a q35 chipset may already add this type of controller by default.