search

hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer
Apache License 2.0
401 stars 488 forks source link

Update repo to work with TF 0.13 #192

Closed brikis98 closed 4 years ago

brikis98 commented 4 years ago
  1. Update required_version to 0.12.26 everywhere.
  2. Add pre-commit hooks.
  3. Update version numbers in CI build.
  4. Run go fmt.
  5. Fix folder copy in a Packer template. Our previous Circle CI Docker image used to check out the repo into a folder called terraform-aws-consul, so the Packer template could use a file provisioner to copy it from that folder name. Our new Circle CI Docker image uses a different folder name (e.g., project), so we have to update the Packer template to work even if it doesn't know the folder name.
  6. Add retries for Packer builds for what looks like a transient build failure.
brikis98 commented 4 years ago

Tests passed! This is ready for review.

ina-stoyanova commented 4 years ago

Not sure why (I can't log in to see Terraform Cloud ) - but it's failing 🤔

brikis98 commented 4 years ago

Not sure why (I can't log in to see Terraform Cloud ) - but it's failing 🤔

We don't really use Terraform Cloud... I think that might be some random experiment @josh-padnick is running. I pinged him to ask. That said, for the purposes of this PR, it's safe to ignore. Our tests are the ones in CircleCi.

brikis98 commented 4 years ago

Thanks for the review! Merging now.