Update systemd-resolved script for Ubuntu 20.04

hashicorp / terraform-aws-consul

A Terraform Module for how to run Consul on AWS using Terraform and Packer

Apache License 2.0

401 stars 488 forks source link

Update systemd-resolved script for Ubuntu 20.04 #197

Closed mirkop-mattr closed 3 years ago

mirkop-mattr commented 4 years ago

Systemd is also available on Ubuntu 20.04. The updates will allow the provisioning script to run.

robmorgan commented 4 years ago

Thanks @mirkop-mattr! How did you test this? I guess we should explitity add Ubuntu 20.04 as a target to our tests and Packer templates.

mirkop-mattr commented 4 years ago

Thanks @mirkop-mattr! How did you test this? I guess we should explitity add Ubuntu 20.04 as a target to our tests and Packer templates.

Apologies I can try to run the tests tomorrow. I have actually build a Ubuntu 20.04 AMI myself, but with a packer template that did not include 16.04 anymore and looked slightly different. So yes it is probably a good idea to run the testsuite.

robmorgan commented 4 years ago

@mirkop-mattr okay as part of this PR I think we also need to include examples + tests for Ubuntu 20.04 otherwise there's no way for our automated test suite to continually validate that this change works correctly. Are you able to add Ubuntu 20.04 to the Packer templates and tests?

Alternatively, you could also try another approach here: https://github.com/hashicorp/terraform-aws-consul/pull/197/files#diff-6c605a7da1f7d7fe7888c86e0165164c3a93d4059ac17be4e64c6cfbe6dc341bR85 that somehow works on all Ubuntu versions greater than 18.04. That way we won't have to explicitly list each distribution. Note: I'm assuming that's probably a bit more difficult than what I've proposed above.

brikis98 commented 4 years ago

Doh, race condition! Looks like I duplicated @robmorgan's comments. Sorry about that 😁

mirkop-mattr commented 4 years ago

Thanks for the feedback! Do you want me to update the circle ci configuration as well?

mirkop-mattr commented 4 years ago

@mirkop-mattr okay as part of this PR I think we also need to include examples + tests for Ubuntu 20.04 otherwise there's no way for our automated test suite to continually validate that this change works correctly. Are you able to add Ubuntu 20.04 to the Packer templates and tests?

Alternatively, you could also try another approach here: https://github.com/hashicorp/terraform-aws-consul/pull/197/files#diff-6c605a7da1f7d7fe7888c86e0165164c3a93d4059ac17be4e64c6cfbe6dc341bR85 that somehow works on all Ubuntu versions greater than 18.04. That way we won't have to explicitly list each distribution. Note: I'm assuming that's probably a bit more difficult than what I've proposed above.

Do you have any suggestions for another approach? I could check if the system we are running on is using systemd.

robcxyz commented 3 years ago

Any updates on merging this?

hashicorp-cla commented 3 years ago

All committers have signed the CLA.

1FastSTi commented 3 years ago

@mirkop-mattr , can you sign that CLA?

mirkop-mattr commented 3 years ago

Any chance we can kick off the signing of the CLA again? I have changed email addresses for this account. Or shall I raise a new PR?

brikis98 commented 3 years ago

I don't see any way to do it other than a new PR. Thx!

mirkop-mattr commented 3 years ago

Closing this and raising https://github.com/hashicorp/terraform-aws-consul/pull/217 using different github account.