hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.76k stars 9.12k forks source link

Add OpenBSD amd64 support #19138

Closed fallertsen closed 1 year ago

fallertsen commented 3 years ago

Community Note

Description

Looks like there was OpenBSD support for this provider, but the support was dropped on version 3.0.0, but I couldn't find any reason why. To re-enable the support it should be as simple as adding openbsd as goos in the .goreleaser.yml file.

References

https://registry.terraform.io/v1/providers/hashicorp/aws/versions

This shows that all the releases up until 3.0.0 openbsd/amd64 was supported.

georgeleege commented 3 years ago

I would like to work on this. Do I just need to add openbsd to the .goreleaser.yml file and run the local and acceptance tests from an OpenBSD machine?

fallertsen commented 3 years ago

I think that should be the place to start. Thanks a lot.

knightjoel commented 3 years ago

make test output is below. I'm uncertain about the cost implications of running the acceptance tests so haven't done that yet.

OpenBSD build.packetmischief.ca 6.9 GENERIC.MP#1 amd64

==> Checking that code complies with gofmt requirements...
go test ./...  -timeout=5m -parallel=4
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws   (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/attrmap  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/encryption   [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/envvar   (cached)
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/experimental/nullable    (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/experimental/sync    [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/hashcode (cached)
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/json (cached)
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags (cached)
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/mutexkv  (cached)
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/namevaluesfilters    (cached)
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/naming   (cached)
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/net  (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/acmpca/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/acmpca/waiter    [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/amplify  (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/amplify/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/amplify/lister   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/amplify/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/apigateway/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/apigatewayv2/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/apigatewayv2/lister  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/apigatewayv2/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/applicationautoscaling/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/appmesh/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/appmesh/waiter   [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/apprunner    (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/apprunner/finder [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/apprunner/waiter [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/appstream/finder [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/appstream/waiter [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/autoscaling  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/autoscaling/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/autoscalingplans/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/autoscalingplans/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/backup   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/backup/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/backup/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/batch    [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/batch/equivalency    (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/batch/finder [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/batch/waiter [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/budgets  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/budgets/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/budgets/waiter   [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudformation   (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudformation/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudformation/lister    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudformation/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudfront/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudfront/lister    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudhsmv2/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudhsmv2/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudtrail   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudwatch/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudwatch/waiter    [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudwatchevents (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudwatchevents/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudwatchevents/lister  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudwatchevents/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudwatchlogs/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cloudwatchlogs/lister    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/codebuild/finder [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/codebuild/waiter [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/codestarconnections/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/codestarconnections/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cognitoidentityprovider/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/cognitoidentityprovider/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/costandusagereportservice/finder [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/datasync (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/datasync/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/datasync/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/directconnect    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/directconnect/finder [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/directconnect/lister [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/directconnect/waiter [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/directoryservice/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/directoryservice/lister  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/directoryservice/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/dynamodb/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/dynamodb/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ebs/waiter   [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ec2  (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ec2/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ec2/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ecr/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ecs/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ecs/lister   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ecs/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/efs/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/efs/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/eks  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/eks/finder   [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/eks/token    (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/eks/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/elasticache  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/elasticache/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/elasticache/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/elbv2    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/elbv2/finder [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/elbv2/waiter [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/fsx/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/fsx/waiter   [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/globalaccelerator    (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/globalaccelerator/finder [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/globalaccelerator/waiter [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/glue [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/glue/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/glue/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/guardduty/waiter [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/iam  (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/iam/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/iam/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/imagebuilder [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/imagebuilder/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kafka/waiter [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kinesis/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kinesis/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kinesisanalytics/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kinesisanalytics/lister  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kinesisanalytics/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kinesisanalyticsv2   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kinesisanalyticsv2/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kinesisanalyticsv2/lister    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kinesisanalyticsv2/waiter    [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kms  (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kms/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/kms/waiter   [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/lakeformation    (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/lakeformation/waiter [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/lambda/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/lambda/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/lex/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/macie2/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/macie2/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/mq/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/msk/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/msk/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/mwaa/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/mwaa/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/neptune  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/neptune/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/neptune/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/networkfirewall/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/networkfirewall/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/organizations/finder [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/prometheusservice/waiter [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/quicksight/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ram/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ram/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/rds  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/rds/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/rds/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/redshift [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/redshift/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/redshift/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/route53  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/route53/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/route53/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/route53recoverycontrolconfig/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/route53resolver  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/route53resolver/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/route53resolver/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/s3   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/s3/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/s3control    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/s3control/finder [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/s3control/waiter [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/s3outposts/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/s3outposts/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sagemaker    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sagemaker/finder [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sagemaker/waiter [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/schemas  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/schemas/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/secretsmanager/waiter    [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/securityhub  (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/securityhub/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/securityhub/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/serverlessapplicationrepository/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/serverlessapplicationrepository/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/servicecatalog   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/servicecatalog/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/servicecatalog/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/servicediscovery/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/servicediscovery/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sfn/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sfn/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sns  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sns/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sns/waiter   [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sqs  (cached)
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sqs/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sqs/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ssm/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ssm/waiter   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ssoadmin/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/ssoadmin/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/storagegateway   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/storagegateway/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/storagegateway/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sts/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/synthetics/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/synthetics/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/transfer [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/transfer/finder  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/transfer/waiter  [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/waf/lister   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/wafregional/finder   [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/wafv2/lister [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/workspaces/finder    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/workspaces/lister    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/workspaces/waiter    [no test files]
?       github.com/terraform-providers/terraform-provider-aws/aws/internal/service/xray/waiter  [no test files]
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/tagresource  (cached)
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/tfresource   (cached)
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/vault/helper/pgpkeys (cached)
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/vault/sdk/helper/jsonutil    (cached)
?       github.com/terraform-providers/terraform-provider-aws/version   [no test files]
fallertsen commented 2 years ago

Thanks for the results. It looks like everything is ok with make test.

What do you mean by "I'm uncertain about the cost implications of running the acceptance tests", there should be no cost implication as far as I know.

knightjoel commented 2 years ago

Hi. As stated in DEVELOPMENT.md: "Note: Acceptance tests create real resources, and often cost money to run." If I recall correctly, the acceptance tests create resources across a wide range of services. It's hard to quantify what the cost might be as a first-time contributor.

fallertsen commented 2 years ago

Hi, thanks for pointing it out. I didn't know about this. What should the next step be, then?

knightjoel commented 1 year ago

make test results on OpenBSD 7.2 (go version go1.19.1 openbsd/amd64)

==> Checking that code complies with gofmt requirements...
go test ./...  -timeout=5m
?       github.com/hashicorp/terraform-provider-aws     [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/acctest    8.242s
?       github.com/hashicorp/terraform-provider-aws/internal/attrmap    [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/conns      0.393s
ok      github.com/hashicorp/terraform-provider-aws/internal/create     (cached)
?       github.com/hashicorp/terraform-provider-aws/internal/enum       [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/envvar     (cached)
?       github.com/hashicorp/terraform-provider-aws/internal/errs       [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/experimental/depgraph      (cached)
?       github.com/hashicorp/terraform-provider-aws/internal/experimental/intf  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/experimental/nullable      (cached)
?       github.com/hashicorp/terraform-provider-aws/internal/experimental/sync  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/flex       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/fwplanmodifiers    (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/fwtypes    (cached)
?       github.com/hashicorp/terraform-provider-aws/internal/generate/allowsubcats      [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/generate/checknames        [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/generate/customends        [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/generate/issuelabels       [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/generate/namescapslist     [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/generate/namevaluesfilters 0.658s
?       github.com/hashicorp/terraform-provider-aws/internal/generate/prlabels  [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/generate/servicelabels     [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/generate/servicesemgrep    [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/generate/sweepimp  [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/generate/tags/templates/v1 [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/generate/tags/templates/v2 [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/generate/teamcity  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/provider   0.293s
?       github.com/hashicorp/terraform-provider-aws/internal/provider/fwprovider        [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/sdktypes   (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer     0.544s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/account    0.580s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/acm        6.171s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/acmpca     10.729s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/amp        0.673s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/amplify    0.464s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 4.675s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2       2.736s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling     0.686s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appconfig  0.385s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appflow    0.591s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appintegrations    0.373s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/applicationinsights 0.604s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appmesh    0.448s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apprunner  0.855s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  0.542s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appsync    0.583s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/athena     0.359s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        0.461s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscalingplans   0.673s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/backup     0.559s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/batch      0.701s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    0.574s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ce 0.388s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chime      3.835s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloud9     0.408s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudcontrol       0.832s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation     0.548s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 4.109s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2 0.473s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch        0.620s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail 0.473s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch 0.386s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codeartifact       0.585s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codebuild  0.540s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codecommit 0.334s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline       0.741s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codestarconnections 0.376s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codestarnotifications0.687s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity    0.686s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 0.877s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/comprehend 0.648s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/configservice      0.535s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/connect    2.162s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cur        0.580s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange       0.363s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline       0.545s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datasync   0.367s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dax        0.602s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/deploy     0.376s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/detective  0.570s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/devicefarm 0.473s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/directconnect      0.936s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dlm        0.536s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        0.512s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/docdb      1.731s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ds 0.355s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   0.378s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        23.692s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        0.640s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecrpublic  0.759s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        1.327s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/efs        2.208s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/eks        1.109s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        0.427s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk   0.564s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch      1.063s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elastictranscoder  0.401s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elb        4.544s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      8.404s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/emr        0.558s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/emrcontainers      0.481s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/emrserverless      4.159s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/events     0.517s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/evidently  0.386s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/firehose   0.555s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fis        0.864s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fms        0.389s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/fsx        0.580s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/gamelift   0.393s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glacier    0.507s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator  0.391s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       0.812s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/grafana    0.367s
?       github.com/hashicorp/terraform-provider-aws/internal/service/greengrass [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/guardduty  0.759s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        5.050s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/identitystore      0.614s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder       0.578s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/inspector  0.569s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/inspector2 0.524s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        0.914s
?       github.com/hashicorp/terraform-provider-aws/internal/service/iotanalytics       [no test files]
?       github.com/hashicorp/terraform-provider-aws/internal/service/iotevents  [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafka      0.459s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect       0.523s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kendra     0.518s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces  0.546s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesis    2.039s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalytics   0.847s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalyticsv2 0.463s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesisvideo       0.847s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kms        0.370s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation      0.630s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     2.243s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lexmodels  0.565s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/licensemanager     0.402s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  0.572s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/location   0.692s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/logs       0.774s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/macie      0.493s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/macie2     0.556s
?       github.com/hashicorp/terraform-provider-aws/internal/service/mediaconnect       [no test files]
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert       0.492s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/medialive  0.369s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediapackage       0.432s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediastore 0.579s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/memorydb   0.387s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/meta       0.490s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mq 0.615s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mwaa       3.518s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/neptune    0.475s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall    0.431s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     0.454s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 0.784s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opsworks   0.378s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/organizations      0.492s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/outposts   0.592s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pinpoint   0.417s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pricing    0.434s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/qldb       0.548s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 0.369s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ram        0.919s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1.744s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   0.389s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshiftdata       0.444s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless 0.606s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups     0.437s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroupstaggingapi     0.801s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rolesanywhere      2.809s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53    0.587s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53domains     0.410s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53recoverycontrolconfig 0.625s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness     0.422s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver    0.365s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rum        0.612s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3 13.600s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3control  0.524s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3outposts 1.264s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  0.633s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/schemas    0.716s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager     1.895s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/securityhub        3.740s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/serverlessrepo     0.532s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog     0.606s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery   0.439s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas      0.545s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ses        0.362s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      4.354s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sfn        0.586s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/shield     0.561s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/signer     0.560s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/simpledb   0.396s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sns        0.742s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sqs        0.417s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        0.720s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin   1.042s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway     0.518s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sts        0.719s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/swf        0.423s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/synthetics 0.548s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite    0.360s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transcribe 1.062s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   0.713s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/waf        0.704s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafregional        1.928s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/wafv2      0.784s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/worklink   0.599s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/workspaces 0.795s
ok      github.com/hashicorp/terraform-provider-aws/internal/service/xray       0.495s
ok      github.com/hashicorp/terraform-provider-aws/internal/slices     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/tags       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/tfresource (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/types/duration     (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/vault/helper/pgpkeys       (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/vault/sdk/helper/jsonutil  (cached)
ok      github.com/hashicorp/terraform-provider-aws/internal/verify     0.144s
ok      github.com/hashicorp/terraform-provider-aws/names       (cached)
?       github.com/hashicorp/terraform-provider-aws/version     [no test files]
fallertsen commented 1 year ago

Thanks for this.

@breathingdust what are the next steps?

github-actions[bot] commented 1 year ago

This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.