hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.76k stars 9.11k forks source link

[Enhancement]: add missing metadata arguments to aws_sagemaker_image_version #35931

Open l3ku opened 7 months ago

l3ku commented 7 months ago

Description

In the SageMaker CreateImageVersion API docs (https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_CreateImageVersion.html), there are more arguments available to be set in the API request than in Terraform currently:

{
   "Aliases": [ "string" ],
   "BaseImage": "string",
   "ClientToken": "string",
   "Horovod": boolean,
   "ImageName": "string",
   "JobType": "string",
   "MLFramework": "string",
   "Processor": "string",
   "ProgrammingLang": "string",
   "ReleaseNotes": "string",
   "VendorGuidance": "string"
}

Whereas the Terraform aws_sagemaker_image_version resource only supports setting the image_name and base_image attributes.

Affected Resource(s) and/or Data Source(s)

Potential Terraform Configuration

resource "aws_sagemaker_image_version" "test" {
  image_name = aws_sagemaker_image.test.id
  base_image = "012345678912.dkr.ecr.us-west-2.amazonaws.com/image:latest"

  horovod          = False
  job_type         = "NOTEBOOK_KERNEL"
  ml_framework     = "Tensorflow"
  processor        = "GPU"
  programming_lang = "Python"
  release_notes    = "Release version 1.0.0"
  vendor_guidance  = "STABLE"
}

References

Would you like to implement a fix?

None

github-actions[bot] commented 7 months ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue