Terraform doesn't resen tags on update after initial update failure [Bug]:

[hamzawix]

Terraform Core Version

latest

AWS Provider Version

latest

Affected Resource(s)

aws_servicecatalog_provisioned_product

Expected Behavior

whenever we reapply an update from terraform after initial failure, it should resend all the tags

Actual Behavior

when we apply an update after it initially failed, terraform doesn't resend the tags if the tags on the provisioned product don't change

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

any configuration

Steps to Reproduce

• on terraform define a service catalog provisioned product module
• use that module to provision a product and include the tags
• now the provisioned product is up and running with the tags intact including the cloudformation stack
• remove one of the resources provisioned by cloudformation to cause a failure on the update
• apply an update from terraform by changing the tags
• the update now failed, but we get all the tags and they're updated on service catalog provisioned product
• fix the cloudformation stack drift
• reapply the update from terraform
• now the tags are are not updated in cloudformation cause terraform didn't resend them

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

[github-actions[bot]]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[github-actions[bot]]

[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions[bot]]

This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions[bot]]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.