hashicorp / terraform-provider-azurerm

Terraform provider for Azure Resource Manager
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs
Mozilla Public License 2.0
4.61k stars 4.65k forks source link

azurerm_data_factory doesn't support `SystemAssigned, UserAssigned` for identity type (validation issue) #13471

Closed jmcee1 closed 3 years ago

jmcee1 commented 3 years ago

Community Note

Terraform (and AzureRM Provider) Version

Terraform v1.0.5

Affected Resource(s)

Terraform Configuration Files

resource "azurerm_data_factory" "this" {
  name                = var.name
  location            = var.location
  resource_group_name = var.target_resource_group_name

  identity {
    type         = "SystemAssigned, UserAssigned"
    identity_ids = [azurerm_user_assigned_identity.this.id]
  }
  customer_managed_key_id = var.encryption_key_id
}

Debug Output

Error: expected identity.0.type to be one of [SystemAssigned UserAssigned], got SystemAssigned, UserAssigned

Panic Output

Expected Behaviour

Validation should pass for value SystemAssigned, UserAsssigned

Actual Behaviour

Validation fails for SystemAssigned, UserAsssigned

Steps to Reproduce

  1. terraform apply

Important Factoids

From models.go since v54.0.0:

Type - The identity type. Possible values include: 'FactoryIdentityTypeSystemAssigned', 'FactoryIdentityTypeUserAssigned', 'FactoryIdentityTypeSystemAssignedUserAssigned'

Looks like value missed while migrating to v54.0.0

References

aristosvo commented 3 years ago

Let's give it a try to fix this 👍🏽

aristosvo commented 3 years ago

@jmcee1 I have never seen an issue resolve and being released as quickly as this one, enjoy! 😂🎉🎉

github-actions[bot] commented 3 years ago

This functionality has been released in v2.78.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 3 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.