hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.36k stars 1.75k forks source link

Failing test(s): TestAccDataLossPreventionDiscoveryConfig_Update #19089

Closed melinath closed 3 months ago

melinath commented 3 months ago

Impacted tests

Affected Resource(s)

Failure rates

Message(s)

 Error: Error creating DiscoveryConfig: googleapi: Error 400: For a project, you can have multiple single-table discovery configurations but only one project-level discovery configuration for BigQuery tables.

It looks like the deletion of the DiscoveryConfig failed and the leftover resource was not swept. Initial error was:

testing_new.go:85: Error running post-test destroy, there may be dangling resources: DataLossPreventionDiscoveryConfig still exists at https://dlp.googleapis.com/v2/projects/ci-test-project-nightly-beta/locations/us-central1/discoveryConfigs/8667524838116786959

The ideal fix would be to write a sweeper

Nightly build test history

b/358691074

patrickmoy commented 3 months ago

Sweeper looked fine locally; PR merged. Let me know if tests don't improve after this

melinath commented 3 months ago

Looks like the test passed last night! Closing this issue as resolved.

github-actions[bot] commented 2 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.