hashicorp / terraform-provider-google

Terraform Provider for Google Cloud Platform
https://registry.terraform.io/providers/hashicorp/google/latest/docs
Mozilla Public License 2.0
2.36k stars 1.75k forks source link

VCR tests not posting logs links correctly for composed tests #19930

Open ScottSuarez opened 1 month ago

ScottSuarez commented 1 month ago

What kind of contribution is this issue about?

Other (specify in details)

Details

When a test is composed of multiple sub tests the log link given 404s. The parent test has no associated log file. Each sub test has their own log file. We should either enumerate/list the sub tests directly or link to the log folder instead of the log file. image

--- PASS: TestAccMonitoringAlertPolicy (68.99s)
    --- PASS: TestAccMonitoringAlertPolicy/basic (9.14s)
    --- PASS: TestAccMonitoringAlertPolicy/full (9.02s)
    --- PASS: TestAccMonitoringAlertPolicy/update (16.89s)
    --- PASS: TestAccMonitoringAlertPolicy/mql (8.68s)
    --- PASS: TestAccMonitoringAlertPolicy/log (8.22s)
    --- PASS: TestAccMonitoringAlertPolicy/forecast (9.00s)
    --- PASS: TestAccMonitoringAlertPolicy/promql (8.04s)

Screenshot 2024-10-18 at 1 58 34 PM

References

https://github.com/GoogleCloudPlatform/magic-modules/pull/12052#issuecomment-2423180875 tests-suite

log folder - https://pantheon.corp.google.com/storage/browser/ci-vcr-logs/beta/refs/heads/auto-pr-12052/artifacts/0cfe74a3-2c92-4190-af4a-b2998aa7e6b4/recording?inv=1&invt=AbfHmg&pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))

trodge commented 1 month ago

This seems like a good reason to make log URLs into a template function.