Add `parent_resource_pool_id` to `d/vsphere_resource_pool` to match `r/vsphere_resource_pool`

[desertmoose706]

Terraform Version

Terraform v0.13.5

vSphere Provider Version

• provider registry.terraform.io/hashicorp/vsphere v1.24.2

Affected Resource(s)

resource vsphere_resource_pool data vsphere_resource_pool

Description

Need to reference a resource pool within a Cluster.

E.g. I create the resource pool using this code in multiple clusters in the same datacenter:

resource "vsphere_resource_pool" "resource_pool1" {
    name                    = "Veeam"
    parent_resource_pool_id = data.vsphere_compute_cluster.compute_cluster1.resource_pool_id
}
resource "vsphere_resource_pool" "resource_pool2" {
    name                    = "Veeam"
    parent_resource_pool_id = data.vsphere_compute_cluster.compute_cluster2.resource_pool_id
}

Then seemingly only option to extract data for that pool name is:

data "vsphere_resource_pool" "pool" {
    name          = "Veeam"
    datacenter_id = data.vsphere_datacenter.dc.id
}

Which returns the following error:

Error: error fetching resource pool: path 'Veeam' resolves to multiple resource pools

  on vars.tf line 29, in data "vsphere_resource_pool" "pool":
  29: data "vsphere_resource_pool" "pool" {

Potential Terraform Configuration

Recommend implementing parent_resource_pool_id for data vsphere_resource_pool to match the resource. e.g.:

data "vsphere_resource_pool" "pool" {
    name                    = "Veeam"
    parent_resource_pool_id = data.vsphere_compute_cluster.cluster.resource_pool_id
}

References

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[AspenForester]

I'm running into a similar situation where I need to reference a resource pool whose name is not unique in the data center, but is unique to the Cluster.

[AspenForester]

@desertmoose706 Today I Learned that you can specify the Resource Pool as /Compute Cluster Name/Resource Pool Name That fact is not covered by the vsphere provider documentation but is mentioned in the docs for vmware's "vm" module

I still like your "parent_resource_pool_id" suggestion.