Tempus-1088-privacy-policy UI changes. - Githubissues

hashmapinc / Tempus

Hashmap IIoT Accelerator Framework

Apache License 2.0

29 stars 10 forks source link

Tempus-1088-privacy-policy UI changes. #1092

Closed RachanaGupta01 closed 5 years ago

RachanaGupta01 commented 5 years ago

Thank you for submitting a contribution to Tempus.

In order to streamline the review of the contribution please ensure the following steps have been taken:

For all changes:

[x] Is there a Waffle ticket associated with this PR? Is it referenced in the commit message?
[x] Does your PR title start with Tempus-XXXX where XXXX is the waffle number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically dev)?
[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn clean install at the root Tempus folder?
[ ] Have you written or updated unit tests to verify your changes?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] Have you added documentation for any UI or API related changes to the /docs folder

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

jayeshkapadnis commented 5 years ago

For privacy policy, generally, you don't add support of Internationalisation. There must be some better way to add this instead of dividing them in paragraphs manually. Having said that, for now i am accepting this PR. Just make sure all styles which are duplicated in HTML are replaced by CSS classes