Remove CPP from cabal files?

sid-kap commented 8 years ago

I got the following error when I tried to run stack ghci in the packages/tests directory:

* * * * * * * *
There are issues with this project which may prevent GHCi from working properly.

-XCPP will be used, but it can cause issues with multiline strings.
See https://downloads.haskell.org/~ghc/7.10.2/docs/html/users_guide/options-phases.html#cpp-string-gaps
It is specified for:
    hmatrix:lib hmatrix-gsl:lib hmatrix-special:lib
But not for: 
    hmatrix-glpk:lib hmatrix-tests:lib

To resolve, remove the flag(s) from the cabal file(s) and instead put them at the top of the haskell files.

It isn't yet possible to load multiple packages into GHCi in all cases - see
https://ghc.haskell.org/trac/ghc/ticket/10827
* * * * * * * *

Configuring GHCi with the following packages: hmatrix, hmatrix-glpk, hmatrix-gsl, hmatrix-special, hmatrix-tests
GHCi, version 7.10.2: http://www.haskell.org/ghc/  :? for help
ghc: panic! (the 'impossible' happened)
  (GHC version 7.10.2 for x86_64-unknown-linux):
    Loading temp shared object failed: /tmp/sidharth/ghc8920_0/libghc_4.so: undefined symbol: gsl_min_fminimizer_goldensection

Please report this as a GHC bug:  http://www.haskell.org/ghc/reportabug

Should we remove the CPP declaration in the cabal files, and instead put {-# LANGUAGE CPP #-} pragmas at the top of the files that need it?

albertoruiz commented 8 years ago

Yes, I think so.

sid-kap commented 8 years ago

Cool, I'll send in a PR soon.

haskell-numerics / hmatrix

Remove CPP from cabal files? #174