Open Bodigrim opened 1 month ago
Technically this is a breaking change as-is, since the use of
packUptoLenBytes
means that the input list will be truncated if the list is longer than the size hint suggests.
Yeah, maybe it's better to revert the change to instance IsList StrictByteString
.
We should fix it properly (or at least merge the contents of the Hackage revision into the source repo)
Let's make our lives easier and just backport the revision.
Feel free to push any corrections into this branch.
The existing entries and organization look good to me.
680 also adds
NFData
instances forBufferRange
andBuffer
.672 also changes
fromListN
in theIsList
instance forStrictByteString
.packUptoLenBytes
means that the input list will be truncated if the list is longer than the size hint suggests.672 also moves
toLazyByteString
intoData.ByteString.Builder.Internal
and exports it there.Also, we are still only working around #665 in a Hackage revision. We should fix it properly (or at least merge the contents of the Hackage revision into the source repo) before cutting a release. I can prepare a MR for this tomorrow, if you don't beat me to it.