search

haskell / hackage-security

Hackage security framework based on TUF (The Update Framework)
http://hackage.haskell.org/package/hackage-security
56 stars 48 forks source link

Fix test compatibility with tar 0.5.* #312

Closed felixonmars closed 6 months ago

felixonmars commented 6 months ago

The GenEntry method was added in tar-0.6.0.0 and thus building hackage-security with tar 0.5.* fails with the following errors:

[8 of 8] Compiling Main             ( tests/TestSuite.hs, dist/build/TestSuite/TestSuite-tmp/Main.dyn_o )

tests/TestSuite.hs:267:22: error:
    Not in scope: type constructor or class ‘Tar.GenEntry’
    Perhaps you meant ‘Tar.Entry’ (imported from Codec.Archive.Tar.Entry)
    Module ‘Codec.Archive.Tar.Entry’ does not export ‘GenEntry’.
    |
267 |     testEntries1 :: [Tar.GenEntry Tar.TarPath linkTarget]
    |                      ^^^^^^^^^^^^
andreasabel commented 6 months ago

Mmh, maybe we need to diversify our CI to test with older package versions. E.g. use stack and some LTS snapshots.

andreasabel commented 6 months ago

Do you need a release @felixonmars ?

felixonmars commented 6 months ago

I have patched the Arch build, but it would be helpful for others I think :)