haskell / haskell-ide-engine

The engine for haskell ide-integration. Not an IDE
BSD 3-Clause "New" or "Revised" License
2.38k stars 209 forks source link

Use installed ghc in stack linux builds #1737

Closed jneira closed 4 years ago

jneira commented 4 years ago
jneira commented 4 years ago

I am afraid that the actual configuration is not valid for wrapper-test, cause it assumes that stack will have the correct ghc downloaded or in path. It needs up to two different ghcs (ghc-8.8.1 and ghc-8.6.5) so not sure if it will be enough space for both although we are not downloading the main one, the used to build everything else.

fendor commented 4 years ago

How about we mock the wrapper tests? You think that is possible?

fendor commented 4 years ago

Idea for test-mocking:

jneira commented 4 years ago

Mmm, interesting, but stack with system-ghc needs an executable ghc (without the version suffix) in path, no? (i have to test it) could we cheat stack and make it think that the script is ghc?

In fact, we have the real ghcs! so we could point to the appropiate one for each test. This can be done manually running each test separately and set the path with the appropiate ghc in the bash script. EDIT: No it cant be done in that way cause the execution itself needs the main ghc

Not pretty, though 🤔

jneira commented 4 years ago

but stack with system-ghc needs an executable ghc (without the version suffix) in path, no? (i have to test it)

I was wrong, stack picks a ghc-${version} in path if it needs it so the solution is simpler than i thought: we can set in path the needed ghcs, putting the main one in first place

jneira commented 4 years ago

Ok, the stack linux jobs that has not failed due to the response timeout are successful now, so i think the pr could be merged