Fix #224 - Githubissues

haskell / win32

Haskell support for the Win32 API

http://hackage.haskell.org/package/Win32

Other

98 stars 62 forks source link

Fix #224 #225

Closed BinderDavid closed 9 months ago

BinderDavid commented 9 months ago

Fixes #224

Remove unused imports which lead to warnings (and errors with -Werror)
Add a filepath < 1.5 upper bound to the cabal file. (Edit: Changed upper bound to 1.4.200 which added a lot of deprecation warnings which fail with -Werror)
Minor fix to the cabal file: cabal-version should be first field; changelog.md should be extra-doc-file.

This hopefully fixes the CI.

BinderDavid commented 9 months ago

On appveyor the build runs through again for GHC 9.0. Let's see about the older GHC versions.

@Mistuke I can't see the teamcity logs, so I do not see why they are failing.

BinderDavid commented 9 months ago

The first appveyor build which is failing is for a 32-bit platform. In light of https://gitlab.haskell.org/ghc/ghc/-/issues/18487 maybe we could just drop all 32-bit platforms from CI, since GHC is not supporting them anymore?

Mistuke commented 9 months ago

Hi, thanks for the PRs. I'm traveling till Friday and will review then. Don't worry about the CI. I was planning to rework things after my work deadlines.

Mistuke commented 9 months ago

would you mind rebasing this @BinderDavid

BinderDavid commented 9 months ago

would you mind rebasing this @BinderDavid

Done.

Mistuke commented 9 months ago

Thanks!

Mistuke commented 9 months ago

I've already revised the version on hackage btw, and will release this one tomorrow morning. Need to update the CI release pipeline.