Closed DSorlov closed 2 years ago
Hello @DSorlov! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
custom_components/hasl3/__init__.py
:Line 60:80: E501 line too long (101 > 79 characters) Line 64:80: E501 line too long (136 > 79 characters) Line 74:80: E501 line too long (98 > 79 characters) Line 78:80: E501 line too long (135 > 79 characters) Line 87:80: E501 line too long (99 > 79 characters) Line 93:80: E501 line too long (110 > 79 characters) Line 97:80: E501 line too long (142 > 79 characters) Line 106:80: E501 line too long (99 > 79 characters) Line 112:80: E501 line too long (110 > 79 characters) Line 116:80: E501 line too long (142 > 79 characters) Line 117:24: W291 trailing whitespace Line 126:80: E501 line too long (122 > 79 characters) Line 132:80: E501 line too long (109 > 79 characters) Line 136:80: E501 line too long (141 > 79 characters) Line 148:80: E501 line too long (117 > 79 characters) Line 154:80: E501 line too long (110 > 79 characters) Line 158:80: E501 line too long (142 > 79 characters) Line 177:80: E501 line too long (81 > 79 characters) Line 181:80: E501 line too long (81 > 79 characters) Line 185:80: E501 line too long (81 > 79 characters) Line 189:80: E501 line too long (80 > 79 characters) Line 212:80: E501 line too long (82 > 79 characters) Line 213:80: E501 line too long (82 > 79 characters) Line 214:80: E501 line too long (82 > 79 characters) Line 215:80: E501 line too long (80 > 79 characters) Line 239:80: E501 line too long (99 > 79 characters) Line 241:80: E501 line too long (90 > 79 characters) Line 247:80: E501 line too long (89 > 79 characters) Line 250:80: E501 line too long (91 > 79 characters) Line 253:80: E501 line too long (104 > 79 characters) Line 256:80: E501 line too long (90 > 79 characters) Line 259:80: E501 line too long (81 > 79 characters) Line 308:73: W291 trailing whitespace
custom_components/hasl3/config_flow.py
:Line 102:50: W291 trailing whitespace Line 104:50: W291 trailing whitespace Line 106:52: W291 trailing whitespace Line 126:60: W291 trailing whitespace Line 128:60: W291 trailing whitespace Line 130:62: W291 trailing whitespace Line 201:72: W291 trailing whitespace Line 203:72: W291 trailing whitespace Line 205:74: W291 trailing whitespace
custom_components/hasl3/config_schema.py
:Line 156:80: E501 line too long (265 > 79 characters) Line 160:80: E501 line too long (120 > 79 characters) Line 161:80: E501 line too long (87 > 79 characters) Line 162:80: E501 line too long (81 > 79 characters) Line 164:80: E501 line too long (103 > 79 characters) Line 168:1: E302 expected 2 blank lines, found 1 Line 171:80: E501 line too long (265 > 79 characters) Line 175:80: E501 line too long (120 > 79 characters) Line 176:80: E501 line too long (87 > 79 characters) Line 177:80: E501 line too long (81 > 79 characters) Line 180:6: W291 trailing whitespace Line 182:1: E302 expected 2 blank lines, found 1 Line 185:80: E501 line too long (140 > 79 characters) Line 189:80: E501 line too long (86 > 79 characters) Line 190:80: E501 line too long (87 > 79 characters) Line 192:10: W292 no newline at end of file
custom_components/hasl3/const.py
:Line 81:80: E501 line too long (157 > 79 characters) Line 83:80: E501 line too long (139 > 79 characters) Line 84:80: E501 line too long (110 > 79 characters)
custom_components/hasl3/haslworker/__init__.py
:Line 526:80: E501 line too long (88 > 79 characters) Line 537:15: W291 trailing whitespace Line 554:80: E501 line too long (88 > 79 characters) Line 599:15: W291 trailing whitespace Line 636:80: E501 line too long (80 > 79 characters) Line 638:80: E501 line too long (132 > 79 characters) Line 639:80: E501 line too long (117 > 79 characters) Line 641:80: E501 line too long (128 > 79 characters) Line 642:80: E501 line too long (113 > 79 characters) Line 650:80: E501 line too long (116 > 79 characters) Line 656:80: E501 line too long (103 > 79 characters) Line 656:86: E231 missing whitespace after ',' Line 657:27: W291 trailing whitespace Line 660:49: E127 continuation line over-indented for visual indent Line 662:80: E501 line too long (81 > 79 characters) Line 664:80: E501 line too long (82 > 79 characters) Line 669:80: E501 line too long (85 > 79 characters) Line 672:17: E303 too many blank lines (2) Line 677:1: W293 blank line contains whitespace Line 679:15: W291 trailing whitespace Line 718:80: E501 line too long (80 > 79 characters) Line 720:80: E501 line too long (132 > 79 characters) Line 721:80: E501 line too long (117 > 79 characters) Line 723:80: E501 line too long (128 > 79 characters) Line 724:80: E501 line too long (113 > 79 characters) Line 731:80: E501 line too long (114 > 79 characters) Line 737:80: E501 line too long (103 > 79 characters) Line 737:86: E231 missing whitespace after ',' Line 738:27: W291 trailing whitespace Line 741:49: E127 continuation line over-indented for visual indent Line 743:80: E501 line too long (81 > 79 characters) Line 745:80: E501 line too long (82 > 79 characters) Line 750:80: E501 line too long (85 > 79 characters) Line 753:17: E303 too many blank lines (2) Line 758:1: W293 blank line contains whitespace Line 760:15: W291 trailing whitespace Line 769:80: E501 line too long (81 > 79 characters) Line 783:21: E265 block comment should start with '# ' Line 788:1: W293 blank line contains whitespace Line 795:80: E501 line too long (107 > 79 characters) Line 796:80: E501 line too long (107 > 79 characters) Line 801:80: E501 line too long (95 > 79 characters) Line 802:1: W293 blank line contains whitespace Line 806:80: E501 line too long (85 > 79 characters) Line 808:1: W293 blank line contains whitespace Line 810:1: W293 blank line contains whitespace Line 814:80: E501 line too long (91 > 79 characters) Line 818:80: E501 line too long (117 > 79 characters) Line 819:80: E501 line too long (125 > 79 characters) Line 820:80: E501 line too long (117 > 79 characters) Line 821:21: E265 block comment should start with '# ' Line 824:80: E501 line too long (82 > 79 characters) Line 825:80: E501 line too long (113 > 79 characters) Line 829:80: E501 line too long (89 > 79 characters) Line 830:80: E501 line too long (87 > 79 characters) Line 835:80: E501 line too long (81 > 79 characters) Line 836:80: E501 line too long (82 > 79 characters) Line 837:80: E501 line too long (92 > 79 characters) Line 838:80: E501 line too long (90 > 79 characters) Line 839:80: E501 line too long (82 > 79 characters) Line 840:80: E501 line too long (82 > 79 characters) Line 844:80: E501 line too long (81 > 79 characters)
custom_components/hasl3/rrapi/const.py
:custom_components/hasl3/rrapi/rrapi.py
:Line 23:1: E302 expected 2 blank lines, found 1 Line 40:80: E501 line too long (82 > 79 characters) Line 48:80: E501 line too long (84 > 79 characters) Line 53:80: E501 line too long (88 > 79 characters) Line 58:80: E501 line too long (115 > 79 characters) Line 58:89: E231 missing whitespace after ',' Line 73:80: E501 line too long (113 > 79 characters) Line 73:95: E231 missing whitespace after ',' Line 77:11: E111 indentation is not a multiple of four Line 77:80: E501 line too long (122 > 79 characters) Line 78:11: E111 indentation is not a multiple of four Line 79:11: E111 indentation is not a multiple of four Line 80:11: E111 indentation is not a multiple of four Line 81:11: E111 indentation is not a multiple of four Line 82:11: E111 indentation is not a multiple of four Line 83:11: E111 indentation is not a multiple of four Line 84:11: E111 indentation is not a multiple of four Line 85:11: E111 indentation is not a multiple of four Line 85:31: W291 trailing whitespace Line 86:1: W293 blank line contains whitespace Line 92:1: E303 too many blank lines (4) Line 99:80: E501 line too long (121 > 79 characters) Line 110:80: E501 line too long (107 > 79 characters) Line 110:89: E231 missing whitespace after ',' Line 112:1: E302 expected 2 blank lines, found 1 Line 120:80: E501 line too long (104 > 79 characters) Line 120:87: E231 missing whitespace after ',' Line 121:1: W391 blank line at end of file
custom_components/hasl3/sensor.py
:Line 175:80: E501 line too long (92 > 79 characters) Line 176:80: E501 line too long (94 > 79 characters) Line 181:80: E501 line too long (81 > 79 characters) Line 187:80: E501 line too long (92 > 79 characters) Line 188:80: E501 line too long (92 > 79 characters) Line 193:80: E501 line too long (81 > 79 characters) Line 195:5: E265 block comment should start with '# ' Line 199:80: E501 line too long (124 > 79 characters) Line 200:80: E501 line too long (128 > 79 characters) Line 204:5: E265 block comment should start with '# ' Line 205:80: E501 line too long (82 > 79 characters) Line 351:1: E302 expected 2 blank lines, found 1 Line 373:80: E501 line too long (200 > 79 characters) Line 377:21: E722 do not use bare 'except' Line 378:80: E501 line too long (82 > 79 characters) Line 389:80: E501 line too long (87 > 79 characters) Line 425:5: E303 too many blank lines (2) Line 440:80: E501 line too long (94 > 79 characters) Line 452:80: E501 line too long (80 > 79 characters) Line 457:80: E501 line too long (80 > 79 characters) Line 460:80: E501 line too long (80 > 79 characters) Line 461:80: E501 line too long (90 > 79 characters) Line 462:80: E501 line too long (88 > 79 characters) Line 463:80: E501 line too long (80 > 79 characters) Line 464:80: E501 line too long (80 > 79 characters) Line 466:80: E501 line too long (90 > 79 characters) Line 469:9: E722 do not use bare 'except' Line 471:80: E501 line too long (114 > 79 characters) Line 693:1: E302 expected 2 blank lines, found 1 Line 709:80: E501 line too long (81 > 79 characters) Line 717:80: E501 line too long (94 > 79 characters) Line 722:24: E225 missing whitespace around operator Line 724:39: E231 missing whitespace after ',' Line 734:80: E501 line too long (202 > 79 characters) Line 738:21: E722 do not use bare 'except' Line 739:80: E501 line too long (82 > 79 characters) Line 751:80: E501 line too long (93 > 79 characters) Line 872:80: E501 line too long (94 > 79 characters) Line 887:9: E722 do not use bare 'except' Line 889:80: E501 line too long (114 > 79 characters) Line 891:19: W291 trailing whitespace Line 893:1: E302 expected 2 blank lines, found 1 Line 917:80: E501 line too long (94 > 79 characters) Line 922:24: E225 missing whitespace around operator Line 924:39: E231 missing whitespace after ',' Line 934:80: E501 line too long (202 > 79 characters) Line 938:21: E722 do not use bare 'except' Line 939:80: E501 line too long (82 > 79 characters) Line 950:80: E501 line too long (91 > 79 characters) Line 994:9: E303 too many blank lines (2) Line 1075:80: E501 line too long (94 > 79 characters) Line 1089:9: E722 do not use bare 'except' Line 1091:80: E501 line too long (114 > 79 characters) Line 1093:19: W291 trailing whitespace
custom_components/hasl3/slapi/slapi.py
:Line 164:80: E501 line too long (98 > 79 characters) Line 164:82: E231 missing whitespace after ',' Line 177:68: E231 missing whitespace after ',' Line 177:80: E501 line too long (86 > 79 characters)
[3.1] (2022-09-10)
This is major relase adding Resrobot functionallity BUT with some known upgrade issues due to some bad decisions earlier in development. During some cases the automatic upgrade of sensors might fail and to restore a broken sensor it must be fully removed and then recreated manually. Sorry.
BREAKING CHANGES
sl_find_location
sl_find_trip_id
sl_find_trip_pos
ADDED