search

hathitrust / firebird-common

Other
0 stars 0 forks source link

update focus z-index specificity #101

Closed carylwyatt closed 1 month ago

carylwyatt commented 1 month ago

@giramesh this is staged on dev-3 firebird/pt. Can you check that this fixed the dark button focus issues?

netlify[bot] commented 1 month ago

Deploy Preview for hathitrust-firebird-common ready!

Name Link
Latest commit cc59b8516ad20a6ea8f31eaa367b59a156c2bde2
Latest deploy log https://app.netlify.com/sites/hathitrust-firebird-common/deploys/66be54dd23dfee0008cf8144
Deploy Preview https://deploy-preview-101--hathitrust-firebird-common.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

giramesh commented 1 month ago

✅ Yes, I can see the white box shadow now.

Sidebar note: The active/pressed state has a gray shadow that comes into play - which might not pass 3:1 ratio with the adjacent colors (white bg, focus indicator blue border) - not really dinged by DQ on this. but something we could revisit during post work and design system?

https://github.com/user-attachments/assets/73e70f9f-fcc6-473b-a762-b152107f24b1