hathitrust / firebird-common

Other
0 stars 0 forks source link

DEV-1174: add aria-expanded for navbar search toggle #85

Closed carylwyatt closed 3 months ago

carylwyatt commented 3 months ago

Fixes #73 and 1727026 expand/collapse on search bar isn't setting aria expanded correctly

Added aria-expanded attribute to the Search icon in the navbar to alert screen readers when the search bar is open or closed.

This fix is staged on dev-3 (vpn required): https://dev-3.www.hathitrust.org/

If you inspect the "search 🔍 " button in the navbar, it should now have an aria-expanded attribute set to true if the search bar is toggled to open (default on most pages). Toggle it closed, and the attribute should be set to false.

netlify[bot] commented 3 months ago

Deploy Preview for hathitrust-firebird-common ready!

Name Link
Latest commit 7307505ae35e4cdf904b2b1c3589f76f6f170c17
Latest deploy log https://app.netlify.com/sites/hathitrust-firebird-common/deploys/66707f29d7806b0008da0764
Deploy Preview https://deploy-preview-85--hathitrust-firebird-common.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

carylwyatt commented 3 months ago

@angelinanz @giramesh This is now staged on test. You can test it in any app except page turner.

giramesh commented 3 months ago

I can confirm that I'm able to see the aria-expanded attribute get updated from true/false when the search is expanded/collapsed respectively.