search

hats-finance / HATs-Arbitration-Contracts-0x79a618f675857b45934ca1c413fd5f409cf89735

MIT License
0 stars 0 forks source link

Fix #54 #65

Closed ben-kaufman closed 7 months ago

ben-kaufman commented 8 months ago

Fix #54

aviggiano commented 7 months ago

I did not find any further issues when reviewing the fix

bahurum commented 7 months ago

The fix resolves the issue.

Since release() and withdrawSurplus() can be called after the tokenLock is revoked, I would add the amount sent to the owner() to releasedAmount for accounting consistency.

ben-kaufman commented 7 months ago

Since release() and withdrawSurplus() can be called after the tokenLock is revoked, I would add the amount sent to the owner() to releasedAmount for accounting consistency.

I think it is more accurate as it is, since the amount revoked is not amount that was "released" but an amount that was taken out of the contract like it was never part of it.

bahurum commented 7 months ago

@ben-kaufman if you want "released" to refer only to the amount given to the beneficiary, then I agree it is better as it is. Following the discussions I now believe that this is ok.