hats-finance / Palmera-0x5fee7541ddcd51ba9f4af606f87b2c42eea655be

Palmera hierarchical module
0 stars 1 forks source link

Function visibility order does not comply with best practices #66

Open hats-bug-reporter[bot] opened 4 days ago

hats-bug-reporter[bot] commented 4 days ago

Github username: @mhhacker111 Twitter username: -- Submission hash (on-chain): 0x76a0912d7558d718791991404913347bd3e401f037e9c187e48a42fd2f47fb35 Severity: low

Description: Description\ This is a best practice* that should be followed.

Functions should be grouped according to their visibility and ordered:

constructor receive function (if exists) fallback function (if exists) external public internal private Within a grouping, place the view and pure functions last.

*best practice https://docs.soliditylang.org/en/latest/style-guide.html#order-of-functions

0xmahdirostami commented 4 days ago

Informational, not low issue.