Commit from PR #305 (aka `Updated Mullvad openvpn profiles`) breaks Mullvad

ktetzlaff commented 3 weeks ago

Is there a pinned issue for this?

[X] I have read the pinned issues

Is there an existing or similar issue for this?

[X] I have searched the existing issues

Is there any comment in the documentation for this?

[X] I have read the documentation, especially the FAQ and Troubleshooting parts

Is this related to the container/transmission?

[X] I have checked the container repo for issues

Are you using the latest release?

[X] I am using the latest release

Have you tried using the dev branch latest?

[X] I have tried using dev branch

Config used

Irrelevant.

Current Behavior

After merging PR #305, OpenVPN/Linux in container fails with Options error: Unrecognized option or missing or extra parameter(s) in /etc/openvpn/mullvad/us_all.ovpn:16: service (2.5.9) Use --help for more information..

See https://github.com/haugene/vpn-configs-contrib/pull/305#issuecomment-2297500122 for details.

Expected Behavior

OpenVPN starts without issues.

How have you tried to solve the problem?

Reverting commit 9075182a3dc53694312ae958fc0aecf99d2f004d (aka Updated Mullvad openvpn profiles) from PR #305 solves the issue.

See https://github.com/haugene/vpn-configs-contrib/pull/305#issuecomment-2298391371 for details.

Log output

See https://github.com/haugene/vpn-configs-contrib/pull/305#issuecomment-2297500122

Environment

Shouldn't matter, but for completeness:

OS: Debian Linux 13/testing
Docker: Docker version 20.10.25+dfsg1, build b82b9f3

Anything else?

No response

aj0413 commented 3 weeks ago

ah, was wondering why I was getting a few hundred error emails today from my Synology Nas about this

ktetzlaff commented 3 weeks ago

@penyuan provided a workaround in https://github.com/haugene/vpn-configs-contrib/issues/305#issuecomment-2298751964 (which is better than what I described in the linked comment above):

FWIW, I downloaded the Mullvad files from the previous commit: https://github.com/haugene/vpn-configs-contrib/tree/a189d8f552ff48db16e85e114b743b2fc8b2d06d/openvpn/mullvad

Then, followed the official docs to use it as a custom provider: https://haugene.github.io/docker-transmission-openvpn/supported-providers/#using_a_local_single_ovpn_file_from_a_provider

And for now it works. But this is a stopgap measure, and I hope that the problem will be fixed through an upcoming merge/commit.

hbontempo-br commented 3 weeks ago

Same problem here

No bundled config script found for MULLVAD. Defaulting to external config
Will get configs from https://github.com/haugene/vpn-configs-contrib.git
Repository is already cloned, checking for update
Already up to date.
Already on 'main'
Your branch is up to date with 'origin/main'.
Found configs for MULLVAD in /config/vpn-configs-contrib/openvpn/mullvad, will replace current content in /etc/openvpn/mullvad
Starting OpenVPN using config fr_all.ovpn
Modifying /etc/openvpn/mullvad/fr_all.ovpn for best behaviour in this container
Modification: Point auth-user-pass option to the username/password file
Modification: Change ca certificate path
Modification: Change ping options
Modification: Update/set resolv-retry to 15 seconds
Modification: Change tls-crypt keyfile path
Modification: Set output verbosity to 3
Modification: Remap SIGUSR1 signal to SIGTERM, avoid OpenVPN restart loop
Modification: Updating status for config failure detection
Setting OpenVPN credentials...
adding route to local network 192.168.0.0/16 via 172.18.0.1 dev eth0
Options error: Unrecognized option or missing or extra parameter(s) in /etc/openvpn/mullvad/fr_all.ovpn:14: service (2.5.9)
Use --help for more information.

dgonneau commented 3 weeks ago

Having exact same problem with "Options error" message. Replaced the fr_all.ovpn in /data/docker/transmission-openvpn/vpn-configs-contrib/openvpn/mullvad/ with previous version https://github.com/haugene/vpn-configs-contrib/blob/a189d8f552ff48db16e85e114b743b2fc8b2d06d/openvpn/mullvad/fr_all.ovpn and it works for now until next update.

sntyj commented 2 weeks ago

I created a pull request to roll back these changes, while keeping the IP addresses in place. Please feel free to test and provide feedback on it: https://github.com/haugene/vpn-configs-contrib/pull/312

ajakate commented 2 weeks ago

Another workaround that was pretty easy...

I think this specific error Unrecognized option ... service is only in the _all configs. I switched my mullvad OPENVPN_CONFIG from se_all to se_sto and that got me up and running fine

BananaHammock743 commented 2 weeks ago

@haugene @wickedyoda if you have time to review this it would help out a whole heap of us who have broken Transmission clients 🙏

pkishino commented 2 weeks ago

Have merged in #312

BananaHammock743 commented 2 weeks ago

Many thanks my Transmission is up and working again 🫶

On Sun, 25 Aug 2024 at 5:56 PM, Patrick Kishino @.***> wrote:

Have merged in #312 https://github.com/haugene/vpn-configs-contrib/pull/312

— Reply to this email directly, view it on GitHub https://github.com/haugene/vpn-configs-contrib/issues/311#issuecomment-2308667110, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALUEIP6AVWBVHJQKLMONUA3ZTFWXBAVCNFSM6AAAAABMZQI6AGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYGY3DOMJRGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

haugene / vpn-configs-contrib