hauner / grails-cucumber

a Cucumber plugin for Grails
https://github.com/hauner/grails-cucumber
63 stars 35 forks source link

Added ability to specify feature file and line numbers from command line #24

Closed aharwood closed 11 years ago

aharwood commented 11 years ago

Hi,

I've made a small enhancement to RuntimeOptionsBuilder to allow the specification of which feature file (and optionally line numbers) to run. It seems that this functionality was present in the old addCliFilter(RuntimeOptions) method, but was lost when moving to the new method (I assume because it didn't fit with the style). I've tried to implement it in keeping with how you've done the tags. I've also updated the README to include a section on what can be specified from the command line.

I believe this would allow Issue #11 to be closed.

Example usage:

grails test-app :cucumber features/search.feature:10:20
hauner commented 11 years ago

Hi Adam,

The old addCliFilter was a bit dirty. Use of --options is tricky because grails eats them away. I tried using + instead but I did not like that.

I played around with your code and found a few things that could be improved.

I did not merge your code but it triggered implementation of the dir/file:line filter handling the cases above too.

thanks for working on this :-) !

I plan to release it next week as 0.8.0

aharwood commented 11 years ago

Excellent, this functionality will be really handy. Looking forward to it!