Refactor desktop UI to Buy/Sell XMR

woodser commented 1 month ago

Currently the desktop UI offers these options to buy/sell, where the asset being bought/sold depends on the context:

This issue requests refactoring the desktop UI to be relative to always buying or selling XMR for other assets.

We need to decide exactly how the refactored UI should appear as part of this issue.

XMRZombie commented 1 month ago

The best (for example on the buy part) is renaming 'monero' with FIAT, keeping 'bitcoin' 'others' and displaying 'sell BTC/ETH/ect..' offers inside

monerobull commented 1 month ago

The best (for example on the buy part) is renaming 'monero' with FIAT, keeping 'bitcoin' 'others' and displaying 'sell BTC/ETH/ect..' offers inside

the big BUY & SELL buttons could be changed to something like this to make it easy to understand:

grafik grafik

Now you click on BUY with FIAT / BITCOIN / OTHER when you want to buy Monero and SELL for FIAT / BITCOIN / OTHER which totally makes sense and is what you'd expect from a Monero DEX.

woodser commented 1 month ago

I was considering the following re-design:

BUY XMR | SELL XMR Pay with: Fiat | Crypto | Precious Metals

BUY XMR | SELL XMR Receive: Fiat | Crypto | Precious Metals

This means the tabs Monero, Bitcoin, and Other will be replaced with Fiat, Crypto, and Precious Metals, respectively.

(maybe "Pay with" / "Receive" could be changed to "With" / "For")

monerobull commented 1 month ago

i don't think precious metals should get their own tab. if anything it could be the "Other" tab and on it you can trade all sorts of stuff with more freedom in terms of what you can put in the offer, be that precious metals or WoW gold.

woodser commented 1 month ago

I'd agree except we only offer precious metals in that other tab now.

In the future if we supported other types of assets, we could easily rename the tab to Other, but currently they all fit in the precious metals category.

preland commented 1 month ago

I was considering the following re-design:

BUY XMR | SELL XMR Pay with: Fiat | Crypto | Precious Metals

BUY XMR | SELL XMR Receive: Fiat | Crypto | Precious Metals

This means the tabs Monero, Bitcoin, and Other will be replaced with Fiat, Crypto, and Precious Metals, respectively.

(maybe "Pay with" / "Receive" could be changed to "With" / "For")

Funnily enough, this was basically what I was thinking a while ago. Other than the precious metals being its own tab, which is understandable if we only have precious metals in the “Other” category atm.

monerobull commented 1 month ago

I'd agree except we only offer precious metals in that other tab now.

In the future if we supported other types of assets, we could easily rename the tab to Other, but currently they all fit in the precious metals category.

Can we add CSGO skins? The biggest market for them (Chinese), kicked out all the foreigners and the remaining ones all take enormous fees + are frontrunning their users offers to snipe all good deals.

Trade details should have a button that includes the inspect link for the offered item (they look like this steam://rungame/730/76561202255233023/+csgo_econ_action_preview%20M5375700319123681500A39950351544D7244786053760381826) and opens the item directly in the game.

Moving skins between inventories puts a 7 day hold on the items afterwards so p2p trading is actually the best way to do it, would be a good fit for Haveno imo.

Except for the inspect button, you wouldn't need to really add anything else to the code. That thing and a custom info fox like on pay-by-mail offers should be good enough.

Being totally honest, I don't expect this to get the biggest volume but it would be a cool first edition to the "other" section.

woodser commented 1 month ago

Can we add CSGO skins?

This would be a different type of asset than what's currently listed, because there's no price per unit. Each item has its own independent price, bringing the application closer to a marketplace for goods. We should consider this as part of a separate issue.

If it's ever supported, it's easy to put these under a 'Other' tab.

woodser commented 1 month ago

What do you all think of this?