hawkthorne / hawkthorne-journey

Digital Estate Planning: The Game
https://projecthawkthorne.com
1.09k stars 454 forks source link

Unable to build #670

Closed Myoldmopar closed 12 years ago

Myoldmopar commented 12 years ago

Hi, after a recent pull, I am not able to build. I am on Ubuntu 12.10 64-bit. The error is:

-> make mkdir -p build sed -i '.bak' 's/ac1c2db50f1332444fd0cafffd7a5543/ac1c2db50f1332444fd0cafffd7a5543/g' src/main.lua sed: -e expression #1, char 1: unknown command: `.' make: *\ [love] Error 1

I can certainly provide more information, but didn't want to waste any time in case this was a known problem. I quick browse through recent open and closed issues did not reveal a similar problem.

Thanks!

jhoff commented 12 years ago

Interesting... it looks like you have a different version of sed

For what it's worth though, you don't have to make everything in order to play the game ( I.E. you don't need a .love file )

You only have to do make maps to compile your .tmx and then love src to run the game from the src directory.

runtime1point0 commented 12 years ago

Some research suggests removing the space after -i may fix it for both versions of sed, gnu sed and system sed (so -i.bak instead of -i[space]'.bak' [I also removed the quotes since the sources I found didn't use it]).

Myoldmopar commented 12 years ago

Thanks so much for writing back. I've been building and playing it for months now, I love it.

As for sed, here's my version: -> sed --version GNU sed version 4.2.1 Copyright (C) 2009 Free Software Foundation, Inc.

I confirm that I can build it @ 81c09b5 (before last Makefile changes), and then fast-forward a few revisions to 235398e (after last Makefile changes) and I can no longer build it with the OP error.

Let me know if I can provide any other information...I'm surprised I'm the only one seeing this.

Myoldmopar commented 12 years ago

The comment above about the sed argument format seems to have fixed it. I am working right now, so I haven't tested any recent commit things, but it does build and run fine.

Thanks!

runtime1point0 commented 12 years ago

I suspect most other people aren't doing a full build, so they wouldn't notice it. Plus, the commit that broke your build (2695c288bd) is fairly recent (within the last week). Glad you seem to have it working. I submitted a pull request with the change. We'll see if it works on the other version of sed.

Myoldmopar commented 12 years ago

Saw the pull request go by, thanks.

Good luck with everything.

On Thu, Nov 29, 2012 at 9:49 AM, runtime1point0 notifications@github.comwrote:

I suspect most other people aren't doing a full build, so they wouldn't notice it. Plus, the commit that broke your build (2695c28https://github.com/kyleconroy/hawkthorne-journey/commit/2695c288bd) is fairly recent (within the last week). Glad you seem to have it working. I submitted a pull request with the change. We'll see if it works on the other version of sed.

— Reply to this email directly or view it on GitHubhttps://github.com/kyleconroy/hawkthorne-journey/issues/670#issuecomment-10853154.

Edwin Lee Doctoral Candidate, Oklahoma State University ASHRAE Student Member, Former ASHRAE OSU Student Branch President Office: ATRC 303: 405-744-3727

kyleconroy commented 12 years ago

All good to go. Happy building.