search

hay-kot / homebox

Homebox is the inventory and organization system built for the Home User
https://hay-kot.github.io/homebox/
GNU Affero General Public License v3.0
2.71k stars 213 forks source link

Change maintenance dialog field order #909

Open Spreadcat opened 6 months ago

Spreadcat commented 6 months ago

What type of PR is this?

What this PR does / why we need it:

This PR changes the order of the fields in the maintenance dialog. The original order was

title/completed/scheduled/notes/costs.

This changed to title/scheduled/completed/costs/notes. When using the maintenance dialog the scheduled information was always earlier available than when the maintenance was completed. Therefore that field coming right after the title seems to be more sensible.

Something similar was/is true for the order of costs and notes. In my use cases I have more often a value for cost than actually for notes, which is why it seems more meaningful to have the field coming before notes. Also notes is the bigger field, which layout wise makes it slightly more sensible to put to the end. That way Costs does not get completely out of focus.

Which issue(s) this PR fixes:

None

Testing

Release Notes

Changing the order of the fields in the maintenance dialog of an asset.
Spreadcat commented 6 months ago

Not sure why these checks fail. It looks to me like something is wrong with the CICD infrastructure.