Small issue with firefox's drag fix

hayden-fr / ComfyUI-Model-Manager

Manage models: browsing, donwload and delete.

GNU General Public License v3.0

64 stars 21 forks source link

Small issue with firefox's drag fix #23

Closed EtSL33py closed 2 months ago

EtSL33py commented 2 months ago

window.screenLeft and window.screenTop are subtracted from the coordinates to correct them. It works well when browser window is not maximized. When window is maximized in Windows window.screenLeft and window.screenTop are equal to -8, it adds a small offset and sometimes makes it a little difficult to drag onto a node widget

https://github.com/hayden-fr/ComfyUI-Model-Manager/blob/6f61688bd827c9e7abdb2e1f3ae34bb2ed0ce16e/web/model-manager.js#L113-L116

cdb-boop commented 2 months ago

Do you know why it is equal to -8? Is there some global variable/constant it is related to?

EtSL33py commented 2 months ago

A maximized window in Windows has a position of (-8, -8). This is Windows's way to hide a windows's borders, which in Windows 10 are still 8px width. Idk what happens in Windows 11