hbenl / vscode-mocha-test-adapter

Mocha Test Adapter for the VS Code Test Explorer
MIT License
91 stars 31 forks source link

Remove vscode-test-explorere dependency #184

Closed rickstaa closed 3 years ago

rickstaa commented 3 years ago

I think we should remove the dependency to the vscode-test-explorer since it will be deprecated now the vscode test API has been finalized (see this announcement). I quickly tried to remove this dependency myself in #33 but received the following errors when building:

src/core.ts:354:115 - error TS2571: Object is of type 'unknown'.

354       this.testsEmitter.fire(<TestLoadFinishedEvent>{ type: 'finished', errorMessage: `Couldn't establish IPC:\n${err.stack}` });

I don't think there are related to the code changes I made are related. I sadly don't have time to investigate this further due to some pressing deadlines.

hbenl commented 3 years ago

See https://github.com/hbenl/vscode-mocha-test-adapter/pull/183#issuecomment-974859253