search

headcr4sh / node-maven

Maven for Node.js
Apache License 2.0
18 stars 14 forks source link

Allow using ./mvnw wrapper #13

Closed aegershman closed 6 years ago

aegershman commented 6 years ago

I don't have maven installed on my system. I wanted to use my project's maven wrapper. This allows you to specify the maven binary executable to use relative to cwd. Example:

const maven = require('maven').create({
  cwd: '/project/path/here/',
  cmd: './mvnw'
})
headcr4sh commented 6 years ago

I like the idea of using the maven wrapper. Maybe the maven wrapper should even be the default option if it exists in the directory pointed to by cwd. That would simplify things even more.

aegershman commented 6 years ago

Good idea, thank you. I'll work on it after work.

aegershman commented 6 years ago

Ah sorry, I still haven't had time to have this check for mvnw in the cwd directory. I'm at a conference this week. If no one else tackles it in the next week, I'll work on it this weekend.

headcr4sh commented 6 years ago

No problem.

I decided to merge your PR, because it seems to provide enough value even without an "automatic mvnw detection"-mechanism... ;-)