search

headcr4sh / node-maven

Maven for Node.js
Apache License 2.0
18 stars 14 forks source link

Args should not be const #6

Closed yjaaidi closed 8 years ago

yjaaidi commented 8 years ago

Args is modified by 'args = args.concat(commands);' and thus is not a const.

headcr4sh commented 8 years ago

Duplicate of #5 Thanks for the PR anyway... took me a while to incorporate the fix. (sorry!)

yjaaidi commented 8 years ago

Thanks! Sorry, I didn't notice it was a duplicate . On mer. 20 avr. 2016 at 07:24, Benjamin P. Jung notifications@github.com wrote:

Duplicate of #5 https://github.com/headcr4sh/node-maven/pull/5 Thanks for the PR anyway... took me a while to incorporate the fix. (sorry!)

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/headcr4sh/node-maven/pull/6#issuecomment-212264762