search

headlamp-k8s / headlamp

A Kubernetes web UI that is fully-featured, user-friendly and extensible
https://headlamp.dev
Apache License 2.0
2.37k stars 170 forks source link

Helm Chart has "persistentVolumeClaim" but it does nothing #1725

Open remram44 opened 9 months ago

remram44 commented 9 months ago

Setting persistentVolumeClaim.enabled to true creates a PVC but it is not used for anything.

knrt10 commented 9 months ago

Hi @remram44. PVC's when enabled can be used for mounting the plugins folder. You have to specify the volume in values.yaml as well for PVC to bound with headlamp deployment. 

volumes:
  - name: example-volume
    # Define your volume type and its attributes
    persistentVolumeClaim:
      claimName: your-pvc-name  # This should match the name of the PersistentVolumeClaim you created

Does this answer your question?

remram44 commented 9 months ago

That is a very unique take on a Helm chart. Why not just have a pluginsPersistentVolumeClaim setting that actually does the work?

yolossn commented 9 months ago

The idea behind keeping the volume and volumeMount values user configurable was to provide flexibility in the way the user wants to configure it. There can be cases when the user wants to use an existing pvc or use the same volumeMount in an init container to setup plugins etc.

remram44 commented 9 months ago

If you want to use an existing PVC or custom PVCs the you don't need the persistentVolumeClaim section, only the volumes section of the chart.

illume commented 4 months ago

Why not just have a pluginsPersistentVolumeClaim setting that actually does the work?

This seems like a good idea to make it more specific. Now we'd have to keep persistentVolumeClaim around for backwards compatibility.

If we don't include a pluginsPersistentVolumeClaim, probably we should at least improve the documentation so it's clear what it is for and what it can be used for.