frontend: PluginSettings: Use author for plugin origin

headlamp-k8s / headlamp

A Kubernetes web UI that is fully-featured, user-friendly and extensible

https://headlamp.dev

Apache License 2.0

2.42k stars 170 forks source link

frontend: PluginSettings: Use author for plugin origin #2572

Closed skoeva closed 6 days ago

skoeva commented 2 weeks ago

This change makes the formatting of the plugin names consistent, using the plugin author for the origin value. When the author is not set, the default origin is "Unknown".

Fixes: #2544

Testing

[X] Open Headlamp and navigate to the plugin settings
[X] Note the consistent plugin name formats and author listed under the origin column

illume commented 1 week ago

Can you please split the commits to changes in separate components out? (Maybe it’s just the subtitle change that could be put in its own commit… but there’s lots of files changed so I could have missed something else.)

illume commented 1 week ago

I wonder if we can use the fit repo if it’s there instead of unknown? Also maybe that should even be displayed… because it can be more useful than whatever the author is put there.

Just a thought, I don’t think adding the GitHub repo should be done in this PR.

We should however make sure all our plugins have the author in the package.json (Also separate to this PR)

skoeva commented 1 week ago

@illume added a separate commit for the subtitle change, lmk if this should be split up further to reflect the change itself vs the context it's being used in