search

headshot2017 / re-plants-vs-zombies

Fork of Patoke's PVZ GOTY decompilation with the intention of porting the game to other platforms (including game consoles)
Creative Commons Zero v1.0 Universal
9 stars 0 forks source link

Various Small Fixes #2

Closed spaghetto207 closed 2 months ago

spaghetto207 commented 2 months ago

Fixes Various Minigames

headshot2017 commented 2 months ago 
[15/128] Building CXX object CMakeFiles/re-plants-vs-zombies.dir/Lawn/Challenge.cpp.obj
FAILED: CMakeFiles/re-plants-vs-zombies.dir/Lawn/Challenge.cpp.obj 
D:\a\_temp\msys64\mingw32\bin\c++.exe -DWINDOWS -D_DEBUG -ID:/a/re-plants-vs-zombies/re-plants-vs-zombies/SexyAppFramework -ID:/a/re-plants-vs-zombies/re-plants-vs-zombies/SexyAppFramework/sound/SDL-Mixer-X/include -ID:/a/re-plants-vs-zombies/re-plants-vs-zombies/SexyAppFramework/platform/pc -isystem D:/a/_temp/msys64/mingw32/include/SDL2  -MD -MT CMakeFiles/re-plants-vs-zombies.dir/Lawn/Challenge.cpp.obj -MF CMakeFiles\re-plants-vs-zombies.dir\Lawn\Challenge.cpp.obj.d -o CMakeFiles/re-plants-vs-zombies.dir/Lawn/Challenge.cpp.obj -c D:/a/re-plants-vs-zombies/re-plants-vs-zombies/Lawn/Challenge.cpp
D:/a/re-plants-vs-zombies/re-plants-vs-zombies/Lawn/Challenge.cpp:3111:7: error: redefinition of 'void Challenge::DrawRain(Sexy::Graphics*)'
 3111 | }void Challenge::DrawRain(Graphics* g)
      |       ^~~~~~~~~
D:/a/re-plants-vs-zombies/re-plants-vs-zombies/Lawn/Challenge.cpp:3068:6: note: 'void Challenge::DrawRain(Sexy::Graphics*)' previously defined here
 3068 | void Challenge::DrawRain(Graphics* g)
      |      ^~~~~~~~~

you should try to compile your code first, or at the very least check the github actions workflows on your fork and see if they successfully compile

spaghetto207 commented 2 months ago

i cant seem to test on windows. theres alot of posix functions unavaliable for windows like unistd and pthreads. but i just fixed this

headshot2017 commented 2 months ago

you might be using visual studio. i use MSYS2 MinGW to compile on windows