Closed HeuristicLab-Trac-Bot closed 11 years ago
Please use absolute instead of relative paths for assembly references. Otherwise only people with the same folder structure can build this plugin.
r9176: updated trading plugin to work with current trunk version
r9213: changed the ranges for buy/hold/sell signals (1/3, 1/3, 1/3)
This should be integrated into the trunk and a blog post should be published that discusses the implementation.
r9743: updated classes in trading branch to work with current trunk version of HL.
r9744: refactoring: removed unused classes, unified calculation of profits and signals, implemented profit-evaluator.
r9797: created a separate plug-in for views (remaining commits)
r9808 (not migrated): deleted feature branch (trading) after trunk merge
r9811: removed empty folders from project file and set svn:ignore properties
r9812: removed plugin references and change return type to IConstrainedValueParameter
Review comments:
- What is the purpose of the Problem class and why is it creatable?
- The grammar in the symbolic trading problem is configured in a weird way (all symbols are enabled).
- Creating a GA + symbolic trading problem is not executable as an index out of range exception occurs.
- There is no way to import new data in the problem, which makes the problem practically useless.
- Better variable naming in ProfitCalculator (e.g., c,p,sum).
- Symbolic.SolutionView is superfluous.
Replying to [comment:34 mkommend]:
Review comments:
- What is the purpose of the Problem class and why is it creatable? r9939: the file has been deleted
- The grammar in the symbolic trading problem is configured in a weird way (all symbols are enabled). r9941: configured the grammar of the problem for GP trading as a standard time series problem grammar
- Creating a GA + symbolic trading problem is not executable as an index out of range exception occurs. This is actually a bug in way how the linear interpreter calls the old interpreter (see #2021). After r9944 the bug does not occur anymore.
- There is no way to import new data in the problem, which makes the problem practically useless. r9964: added a problem instance provider for the trading problem (the provider downloads historic FX rates from ECB).
- Better variable naming in ProfitCalculator (e.g., c,p,sum). r9938: variable names have been improved.
- Symbolic.SolutionView is superfluous. r9940: deleted unnecessary class Symbolic.SolutionView
r9989: worked on problem instance providers for trading problem
- fixed a bug in the ECB problem instance provider (reversed time series)
- improved the ProblemInstanceProviderViewGeneric class to show a progress bar while loading the problem instance
- fixed the build fail (in SolutionLineChartView)
- disabled "Variable" symbol in default time series grammar
- in the line chart use two different axis to display signals and prices
- in the line chart display profits for training and test partitions separately
- fixed hard-coded strings in SolutionView
- added plugin dependency
Issue migrated from trac ticket # 1508
milestone: HeuristicLab 3.3.9 | component: Problems.DataAnalysis | priority: low | resolution: done
2011-05-04 13:34:16: @gkronber created the issue