hearmeneigh / fchat-rising

A heavily modded F-Chat 3.0 client for F-List
https://hearmeneigh.github.io/fchat-rising/
MIT License
39 stars 17 forks source link

[Bug]. F-chat update breaking client #377

Closed EdibleCookie closed 1 month ago

EdibleCookie commented 1 month ago

Upon updating to 1.27.0 The F-chat client breaks

[Window Title]
Error

[Main Instruction]
A JavaScript error occurred in the main process

[Content]
Uncaught Exception:
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type number (2012)
    at new NodeError (node:internal/errors:371:5)
    at validateString (node:internal/validators:119:11)
    at resolve (node:path:167:9)
    at Module.6147 (C:\Users\Edibl\AppData\Local\fchat\app-1.27.0\resources\app\main.js:2:112814)
    at i (C:\Users\Edibl\AppData\Local\fchat\app-1.27.0\resources\app\main.js:2:913502)
    at Object.4160 (C:\Users\Edibl\AppData\Local\fchat\app-1.27.0\resources\app\main.js:2:858830)
    at i (C:\Users\Edibl\AppData\Local\fchat\app-1.27.0\resources\app\main.js:2:913502)
    at Object.2312 (C:\Users\Edibl\AppData\Local\fchat\app-1.27.0\resources\app\main.js:2:864604)
    at i (C:\Users\Edibl\AppData\Local\fchat\app-1.27.0\resources\app\main.js:2:913502)
    at C:\Users\Edibl\AppData\Local\fchat\app-1.27.0\resources\app\main.js:2:913940
    at Object.<anonymous> (C:\Users\Edibl\AppData\Local\fchat\app-1.27.0\resources\app\main.js:2:913965)
    at Module._compile (node:internal/modules/cjs/loader:1116:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1169:10)
    at Module.load (node:internal/modules/cjs/loader:988:32)
    at Module._load (node:internal/modules/cjs/loader:829:12)
    at Function.c._load (node:electron/js2c/asar_bundle:5:13343)

[OK]

This is from updating from 1.26.0 - 1.27.0

FatCatClient commented 1 month ago

I can at least confirm this error both occurs on fresh installations, is platform independent (happened on Win11, MacOS and Debian) and also happens when I try and build the installer locally.

My first guess it has to do with this commit, @hearmeneigh.

Edit:

For anyone stumbling onto this thinking they've broken their installation, if you install the previous version 1.26.2 it should work properly. You'll just be stuck with the old version for the time being.

SyrantSoDx commented 1 month ago

I did have to revert my installation as well, I got this exact error.

Fylifa commented 1 month ago

Same error here!

hearmeneigh commented 1 month ago

Fixed with 1.27.1 release. Thanks for the report!

FatCatClient commented 1 month ago

This does not appear to be fixed in 1.27.1 @hearmeneigh

EdibleCookie commented 1 month ago

Seconded. A friend just advised me that the same error is popping up. Can this be reopened? @hearmeneigh

hearmeneigh commented 1 month ago

Fixed (again) in 1.27.3.