heavyai / heavyai-charting

Dimensional charting built to work natively with crossfilter rendered using d3.js
https://heavyai.github.io/heavyai-charting/
Other
399 stars 73 forks source link

[FE-16125][FE-16114][FE-16108][FE-16-111] Contour error on layer destroy, add contour case for bounding box query #610

Closed johallar closed 1 year ago

johallar commented 1 year ago

Takes care of a few bugs:

FE-16125, FE-16114,FE-16-111 - Contour layer throws errors when trying to destroy the layer which causes problems when removing required measures/dimensions. Poly layer mixin assumes dimension() exists, but not the case for contours. This just makes sure that dimension() exists before chaining. FE-16108 - Contour layer skipped bounding box query during initial implementation, this adds the special contour case to make sure viewport bounding box is included in the query.

Merge Checklist

:wrench: Issue(s) fixed:

:smoking: Smoke Test

:ship: Merge