Closed johallar closed 1 year ago
Ok looks like some of those issues are just on the master layer (namely the weird 0 overlay), but the values still seem a bit random (although maybe this is just the data.....not exactly sure what we're measuring here with the colors) and the low value is still appended with a "m". I do see this branch was addressing a ticket re: legend positioning, so if we want to open a separate investigative issue around this behavior and merge this one as-is I'm also fine with it :)
https://github.com/heavyai/heavyai-charting/assets/15268289/5e73652e-61b8-4431-a648-74623fdc83f1
You're call - if you want to handle those separately I'm fine with it; in that case, this looks good to go as it addresses the ticket scope.
Hm, yeah we've never had a stacked legend on a coordinate grid chart which is probably why we haven't seen the 0
hover thing before. That's coming from the axes, where you can manually input min/max values.
As far as the m
, this uses the same formatting function as the rest of the legends so I think this is how immerse just currently formats numeric legends. Scatter chart on master:
Wondering if the m
is coming from "milli" prefix:
I'll give both of these a quick look, but I think re-positioning and formatting still mostly a win with some good call outs for weird behavior interactions that we should look into separately.
😌 The position was all driven from the
useMap
argument passed to raster chart. This enabled individual layers to determine their own legend position but falls back to theuseMap
logicThis also calls the same format function that legend v1 calls so we don't get crazy precision in the legend values (eg. 45.123853434534)
Before
After:
Legend Position:
Format legend values:
Merge Checklist
:wrench: Issue(s) fixed:
:smoking: Smoke Test
:ship: Merge