heavyai / heavyai-charting

Dimensional charting built to work natively with crossfilter rendered using d3.js

https://heavyai.github.io/heavyai-charting/

Other

399 stars 73 forks source link

[FE-17342] Cast as big int to avoid non integer in modulo operation errors #660

Closed johallar closed 1 year ago

johallar commented 1 year ago

Merge Checklist

:wrench: Issue(s) fixed:

[ ] Author referenced issue(s) fixed by this PR:
[ ] Fixes #0

:smoking: Smoke Test

[ ] Works in chrome
[ ] Works in firefox
[ ] Works in safari
[ ] Works in ie edge
[ ] Works in ie 11

:ship: Merge

[ ] author crafted PR's title into release-worthy commit message.

johallar commented 1 year ago

Ah dist/charting.js wasn't updated with the sample_ratio PR, but I have two that are way behind RN.I'll get those dist changes commited with alllll the changes + immerse updated with the latest

cmatzenbach commented 1 year ago

Ah dist/charting.js wasn't updated with the sample_ratio PR, but I have two that are way behind RN.I'll get those dist changes commited with alllll the changes + immerse updated with the latest

Yeah just realized this when you opened the ticket about dist/ - my bad ☹️